Last modified: 2007-10-11 23:59:27 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11632 - rctype (list=recentchanges) should use words rather than numbers
rctype (list=recentchanges) should use words rather than numbers
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
1.12.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-10-11 13:24 UTC by Roan Kattouw
Modified: 2007-10-11 23:59 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Roan Kattouw 2007-10-11 13:24:19 UTC
Currently, list=recentchanges returns rctype="0" for normal edits, rctype="1" for page creations, and rctype="3" for log messages (types 2 and 4 being deprecated and unused (AFAIK) numbers for page moves and moves over redirect respectively). For clarity, future-proofness and all that good stuff, the numbers should be changed to words that resemble the constants in Defines.php:

/**#@+
 * RecentChange type identifiers
 * This may be obsolete; log items are now used for moves?
 */
define( 'RC_EDIT', 0);
define( 'RC_NEW', 1);
define( 'RC_MOVE', 2);
define( 'RC_LOG', 3);
define( 'RC_MOVE_OVER_REDIRECT', 4);

I would like to suggest type="edit" for type="0", type="new" for type="1" and type="log" for type="3". For safety (wikis upgraded from a very old version to 1.12 or wikis with very a long $wgRCMaxAge) type="move" (2) and type="move over redirect" (4) should also be added.
Comment 1 Daniel Cannon (AmiDaniel) 2007-10-11 23:59:27 UTC
Committed as r26615.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links