Last modified: 2014-09-23 23:41:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11571 - Change CSS so tab spacing is 'before edit' instead of 'after talk'.
Change CSS so tab spacing is 'before edit' instead of 'after talk'.
Status: NEW
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.12.x
All All
: Low trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks: css
  Show dependency treegraph
 
Reported: 2007-10-05 21:29 UTC by Zachary Hauri
Modified: 2014-09-23 23:41 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch to do what is described in the description (468 bytes, patch)
2007-10-05 21:29 UTC, Zachary Hauri
Details
Updated patch (486 bytes, patch)
2007-10-08 03:22 UTC, Zachary Hauri
Details

Description Zachary Hauri 2007-10-05 21:29:33 UTC
Created attachment 4220 [details]
patch to do what is described in the description

I am requesting a small change to the file skins/monobook/main.css.  Please change the following:

Make a space between talk and edit tabs by adding a margin to the edit tab, not the talk tab.

Then, any custom tabs added between the talk and edit tabs will be grouped with talk.
Comment 1 Zachary Hauri 2007-10-08 03:22:28 UTC
Created attachment 4241 [details]
Updated patch

This also adds a margin to #ca-viewsource, which sometimes replaces #ca-edit in the event the visitor can't edit.
Comment 2 Mark Clements (HappyDog) 2007-11-23 11:46:28 UTC
This is a bad idea.  Most extra tabs will be action tabs, rather than new pages, and so should be grouped with the edit/delete/move/etc. tabs.

If this is an issue specific to your own wiki, fix it by editing MediaWiki:Monobook.css.

If you think this is something that needs 'fixing' in MediaWiki, then this is not a good solution.  A better solution would be to include separator items in the array of content-actions at the point where the space should be, so new actions can be added on whichever side is most appropriate.  The monobook skin should use this entry to create the space (probably using in-line CSS) and other skins should ignore it.
Comment 3 Brion Vibber 2008-02-01 21:53:51 UTC
There are two distinct groups of tabs: the article / talk set, and the action set. Each of the two groups may have an active/selected tab. It's all kind of funky. :)

Possibly there should be a grouping around each section, rather than trying to attach spacing to the individual tabs.
Comment 4 Daniel Friesen 2011-02-10 05:15:36 UTC
This could be fixed in 1.18 by using content_navigation instead of content actions (well perhaps with a helper to strip out tabs marked redundant), as long as we don't mind the extra markup (ie: It would no longer be one list, it would be separate lists like in Vector).

Do people really care now that we have vector?
Comment 5 Mark Clements (HappyDog) 2011-02-10 23:26:46 UTC
(In reply to comment #4)
> Do people really care now that we have vector?

If you mean 'would there be a massive public outcry if Monobook was removed altogether?', then the answer is clearly 'yes'.

If you mean 'should we still try and improve monobook?' then, by extension, the answer must still be 'yes'.
Comment 6 Daniel Friesen 2011-02-10 23:30:57 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > Do people really care now that we have vector?
> If you mean 'should we still try and improve monobook?' then, by extension, the
> answer must still be 'yes'.
Well we have to balance that out with the fact that fixing this will change the markup used in tabs on MonoBook. So just to fix a little margin bug we could potentially break plenty of site customizations of MonoBook related to the tabs.
Comment 7 Sumana Harihareswara 2011-11-10 00:11:21 UTC
I'm adding the "reviewed" keyword since commenters have reviewed the patch author's approach.  Thank you for the patch, Zachary.  If you have time to revise and resubmit, please come into #mediawiki on freenode IRC and talk with us about how to fix this better!  Thanks again.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links