Last modified: 2008-03-18 23:50:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T13563, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 11563 - parseQuery method missing from SearchMySQL
parseQuery method missing from SearchMySQL
Product: MediaWiki
Classification: Unclassified
Search (Other open bugs)
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
  Show dependency treegraph
Reported: 2007-10-04 20:49 UTC by Kelly Martin
Modified: 2008-03-18 23:50 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Kelly Martin 2007-10-04 20:49:36 UTC
The SearchMySQL method (includes/SearchMySQL.php, r23531) is missing the parseQuery method.  This is likely to cause all sorts of bad things to happen if you try to run MediaWiki with $wgSearchType set to "SearchMySQL".  Most people will, of course, use SearchMySQL4 instead, and MediaWiki has required MySQL 4 since (I believe) 1.7.

Fix: Eliminate the class & module (by folding all nonoverridden methods in SearchMySQL4), or alias it to SearchMySQL4, or rig the class so that MediaWiki will throw a meaningful error in the event that someone tries to start up MediaWiki with SearchMySQL as the selected search engine.
Comment 1 Brion Vibber 2007-10-15 23:09:14 UTC
Since SearchMySQL3 was obsoleted out, the simplest thing would be to just merge SearchMySQL4 entirely into the SearchMySQL class, and just keep SearchMySQL4 as an alias (child class with no changes).
Comment 2 Brion Vibber 2008-03-18 23:50:18 UTC
Did some cleanup in r32143

Note You need to log in before you can comment on or make changes to this bug.