Last modified: 2008-03-01 15:56:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T13561, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 11561 - invalid case in Wiki.php
invalid case in Wiki.php
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch-reviewed
Depends on:
  Show dependency treegraph
Reported: 2007-10-04 19:50 UTC by Kelly Martin
Modified: 2008-03-01 15:56 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Removes revert case from switch in Wiki.php (328 bytes, patch)
2007-10-04 20:48 UTC, Robert Leverington

Description Kelly Martin 2007-10-04 19:50:52 UTC
In includes/Wiki.php, r24207, line 388, the switch admits to the possiblity of "revert" being a valid action, but there is no "revert" method defined on Article.  An attempt to fetch a page with action=revert yields a zero-byte page (tested on @2007-10-04 1950Z).

Recommended fix: remove "revert" case from switch.
Comment 1 Robert Leverington 2007-10-04 20:48:48 UTC
Created attachment 4212 [details]
Removes revert case from switch in Wiki.php

This bug is in fact more severe than it first appears, currently, when action=revert is appended to the URL a fatal error results. This patch simply removes the action fixing this bug.
Comment 2 Rob Church 2007-10-04 20:54:55 UTC
Fixed in r26414.
Comment 3 Brion Vibber 2007-10-07 20:44:50 UTC
Reverted in r26488, as this of course breaks image reversion, which uses action=revert.
Comment 4 Alexandre Emsenhuber [IAlex] 2008-03-01 15:56:41 UTC
Fixed in r31428.

Note You need to log in before you can comment on or make changes to this bug.