Last modified: 2008-09-06 03:15:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11475 - Superfluous parameter in method call in Math.php
Superfluous parameter in method call in Math.php
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2007-09-27 19:04 UTC by Kelly Martin
Modified: 2008-09-06 03:15 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Kelly Martin 2007-09-27 19:04:39 UTC
Math.php, r24065, line 166, call to Database::replace has an extra argument "array('IGNORE')".  Probably added by someone who mistakenly thought replace takes the same arguments as insert.  Replace does not accept an options argument in Database or any of its subclassed implementations, so it would be wise to check the code in MathRenderer to ensure that it is not relying on behavior which the Database class does not offer.  If the "IGNORE" behavior of insert is important to MathRenderer's use of replace here, then the Database class need to provide it.
Comment 1 Chad H. 2008-09-06 03:15:46 UTC
Removed in r40513

Note You need to log in before you can comment on or make changes to this bug.