Last modified: 2008-09-06 03:15:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T13475, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 11475 - Superfluous parameter in method call in Math.php
Superfluous parameter in method call in Math.php
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
1.12.x
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2007-09-27 19:04 UTC by Kelly Martin
Modified: 2008-09-06 03:15 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Kelly Martin 2007-09-27 19:04:39 UTC 
Math.php, r24065, line 166, call to Database::replace has an extra argument "array('IGNORE')".  Probably added by someone who mistakenly thought replace takes the same arguments as insert.  Replace does not accept an options argument in Database or any of its subclassed implementations, so it would be wise to check the code in MathRenderer to ensure that it is not relying on behavior which the Database class does not offer.  If the "IGNORE" behavior of insert is important to MathRenderer's use of replace here, then the Database class need to provide it.
Comment 1 Chad H. 2008-09-06 03:15:46 UTC 
Removed in r40513
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links