Last modified: 2012-10-27 17:12:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11472 - assigning an id to the "rollback" link
assigning an id to the "rollback" link
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-09-27 12:14 UTC by Huji
Modified: 2012-10-27 17:12 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
adding id to rollback links (961 bytes, patch)
2007-09-27 12:14 UTC, Huji
Details

Description Huji 2007-09-27 12:14:22 UTC
Created attachment 4166 [details]
adding id to rollback links

I think it would be a good idea to assign an id to the "rollback" link. This way, it would be much easier to right a Javasciprt code which adds a link next to it (like one which links to the same address with &bot to its end). I have also created the patch (attached).
Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-11-09 20:52:17 UTC
Comment on attachment 4166 [details]
adding id to rollback links

The patch is not acceptable, because Linker::generateRollback could be called multiple times per page.  Each page must have only one element with a given id.  If a page has two elements with id="rollback-link", it breaks XML validity.

For PageHistory.php, since the line occurs only for $latest, it's fine to add the id.  However, it should start with mw-, like id="mw-rollback-link".
Comment 2 p858snake 2011-04-30 00:09:21 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 3 Sumana Harihareswara 2011-11-10 00:14:55 UTC
+reviewed since Aryeh reviewed the patch.  Thanks for the patch, Huji.
Comment 4 db [inactive,noenotif] 2012-10-27 14:42:39 UTC
Rollback link can occurs multiple times on one page, so a id is bad, but the class 'mw-rollback-link' exist since r17729 for rollbacklinks

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links