Last modified: 2007-09-28 18:54:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11467 - SF should not directly access SMW member variables
SF should not directly access SMW member variables
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
All All
: Normal enhancement (vote)
: ---
Assigned To: Yaron Koren
Depends on:
  Show dependency treegraph
Reported: 2007-09-26 21:39 UTC by Louis Gerbarg
Modified: 2007-09-28 18:54 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Patch to fix direct variable access (3.09 KB, patch)
2007-09-26 21:39 UTC, Louis Gerbarg

Description Louis Gerbarg 2007-09-26 21:39:31 UTC
Created attachment 4164 [details]
Patch to fix direct variable access

SF is directly accessing some SMW object member variables. Those variables are becoming protected in SMW 1.0, which breaks SF. Attached are changes that should fix that. These patch is the same one that I mentioned on the mailing list, but I am making a bug report now that I know that is the preferred way of doing patches. This version actually has one additional places I missed in another file.
Comment 1 Yaron Koren 2007-09-28 18:54:17 UTC
Thanks for the patch; changes applied in version 0.6.4.

Note You need to log in before you can comment on or make changes to this bug.