Last modified: 2007-09-28 18:54:17 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T13467, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 11467 - SF should not directly access SMW member variables
SF should not directly access SMW member variables
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticForms (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-09-26 21:39 UTC by Louis Gerbarg
Modified: 2007-09-28 18:54 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch to fix direct variable access (3.09 KB, patch)
2007-09-26 21:39 UTC, Louis Gerbarg
Details

Description Louis Gerbarg 2007-09-26 21:39:31 UTC
Created attachment 4164 [details]
Patch to fix direct variable access

SF is directly accessing some SMW object member variables. Those variables are becoming protected in SMW 1.0, which breaks SF. Attached are changes that should fix that. These patch is the same one that I mentioned on the mailing list, but I am making a bug report now that I know that is the preferred way of doing patches. This version actually has one additional places I missed in another file.
Comment 1 Yaron Koren 2007-09-28 18:54:17 UTC
Thanks for the patch; changes applied in version 0.6.4.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links