Last modified: 2007-12-03 21:19:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11465 - PRE lower border not shown
PRE lower border not shown
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2007-09-26 20:55 UTC by Huji
Modified: 2007-12-03 21:19 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

bug fix for Monobook skin (264 bytes, patch)
2007-09-26 20:55 UTC, Huji

Description Huji 2007-09-26 20:55:42 UTC
Created attachment 4162 [details]
bug fix for Monobook skin

This image:

Shows how you see in firefox. As you notice, the lower border of the bottom PRE (grey box) is not shown; it is becaue it is overlapped by the object below it (the Categories box). This can be fixed by adding a one pixel margin-bottom to PRE tags. I'm also attaching a patch for it, to fix the bug in Monobook skin. Whether it should be applied to a more general level (like the common CSS files) is what we should discuss, I believe.
Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-11-09 20:59:53 UTC
Comment on attachment 4162 [details]
bug fix for Monobook skin

I can't reproduce this bug in Firefox for Ubuntu Gutsy: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20071022 Ubuntu/7.10 (gutsy) Firefox/  What version of Firefox are you using, on what OS?  What resolution?  What extensions?  If you do random weird stuff like resizing the window, clicking on things, and highlighting things with mouse dragging, does the problem go away?

At any rate, this is a browser bug.  Changing the bottom margin to 1px globally is undesirable; note that the standard bottom margin is (I think) one em, in my case 11px, and you're sharply reducing it.  If we want to add a workaround for this, it needs to be restricted to those Firefox versions that exhibit the problem, it can't change stuff on other browsers.  The first step is to figure out under what circumstances, exactly, the problem occurs.
Comment 2 Huji 2007-11-09 21:05:23 UTC
I was using or when I submitted this bug, and I've updated to recently and it still persists. I'm on Windows XP SP2 if it helps. My screen resolution is 1024*768, and no, neither resizing nor dragging/highlighting fix the problem.

I'll be happy to provide any more details you want. For the record, I'm in full agrement with the approach you have here, and understand what was wrong with the patch I suggested at the first place.
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-11-09 21:17:12 UTC
Maybe you could ask around?  So far we have two data-points.  Try it on some other Windows computers, perhaps?  Ideally, also some Mac and/or Linux, maybe other major versions of Firefox?  Since it's so trivial, it's probably not worth the effort.
Comment 4 Michael Daly 2007-11-10 06:31:38 UTC
The bottom lines don't show on my Windows XP + FF if the page has the donation advert at the top showing and the lines reappear if the donation advert is hidden.  The disappearance is based on position on the page.

This is "normal" FF behaviour for several revisions now (ever since 1.5 at least) on Windows AFAIK.  There is always at least one line that shows text "scrunched" in the vertical dimension. That makes the lowest bit of the font show as missing a few pixels like an entire row or two (3?) of pixels is missing.  It's very noticeable with Wikipedia but it happens with lots of web pages.  I think that this <pre> issue is just the same with the missing bottom pixels coincidently lining up with the bottom line of the <pre> blocks.

I seriously doubt it's a MW problem.  It may be a Windows problem or a VGA driver problem; mine's an Asus video card FWIW.  It might be a FF + Windows problem.
Comment 5 Brion Vibber 2007-12-03 21:19:13 UTC
There sometimes-disappearing borders in Firefox are generally rounding errors in Gecko.

Check it with Firefox 3.0 betas and nightlies and see if that's been fixed; otherwise I guess put it on the pile over at :)

I'll stick this as an INVALID here for now pending confirmation of a local problem.

Note You need to log in before you can comment on or make changes to this bug.