Last modified: 2009-02-28 19:20:10 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11438 - Live Preview chops returned text
Live Preview chops returned text
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.12.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-09-24 13:40 UTC by Voyagerfan5761 / dgw
Modified: 2009-02-28 19:20 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Voyagerfan5761 / dgw 2007-09-24 13:40:35 UTC
When previewing articles longer than somewhere around 2-4 KB using the experimental Live Preview option, the content returned and displayed is chopped off, again somewhere between 2 and 4 KB into the text (HTML-inclusive, it seems). If the Live Preview feature is going to work at all, it cannot chop text like this.
Comment 1 Niklas Laxström 2007-09-24 13:50:28 UTC
I've committed my version of live preview, which fixes this issue, to svn (r26073).
Comment 2 Voyagerfan5761 / dgw 2007-09-24 14:06:00 UTC
Wow, that was fast. Were you already working on it or was it a "duh" solution? Or are you just quick? ;) Anyway, thanks; looking forward to 1.12...
Comment 3 Platonides 2007-09-24 14:09:17 UTC
You can also download the current version from SVN http://www.mediawiki.org/wiki/Download_from_SVN or patch your version with r1=26073&r2=26072&pathrev=26073">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/EditPage.php?view=patch&r1=26073&r2=26072&pathrev=26073 & r1=26073&r2=26072&pathrev=26073">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/preview.js?r1=26073&r2=26072&pathrev=26073
Comment 4 Voyagerfan5761 / dgw 2007-09-24 14:15:19 UTC
If it were mission-critical, I'd probably set up a way for my computer to automatically update the wiki to SVN every week or something, so I could run bleeding-edge fixes, but a patch should be sufficient. The only problem is, I don't know how to apply a patch; my text editor doesn't exactly say...

Anyone know if there are plans for 1.11.1 or 1.11.2 releases? Or are we going to go from 1.11.0 to 1.12.0?
Comment 5 Roan Kattouw 2007-09-24 14:21:42 UTC
(In reply to comment #3)
> r1=26073&r2=26072&pathrev=26073">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/preview.js?r1=26073&r2=26072&pathrev=26073
That should be r1=26073&r2=26072&pathrev=26073&view=patch">http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/skins/common/preview.js?r1=26073&r2=26072&pathrev=26073&view=patch

(In reply to comment #4)
> If it were mission-critical, I'd probably set up a way for my computer to
> automatically update the wiki to SVN every week or something, so I could run
> bleeding-edge fixes, but a patch should be sufficient. The only problem is, I
> don't know how to apply a patch; my text editor doesn't exactly say...
If you run a Linux/UNIX system, you can enter the following on the command line:

cd /where/your/mediawiki/installation/is
patch -p2 --dry-run < /where/your/patch/is/name_of_patch_file

If no errors are returned (only 'patching file includes/EditPage.php' and the like), you can do it for real:

patch -p2 < /where/your/patch/is/name_of_patch_file

If you're on Windows, or don't have command line access, or can't make the patch -p2 thing work, you can always apply the patch manually by removing all lines marked with a '-' and adding all lines marked with a '+'. This is probably a pain in the ass, so you might wanna look for a text editor or some other program that can apply patches.

> Anyone know if there are plans for 1.11.1 or 1.11.2 releases? Or are we going
> to go from 1.11.0 to 1.12.0?
1.11.1 will only contain security fixes relative to 1.11.0, so this one won't be included until 1.12rc1. 

 

Comment 6 Voyagerfan5761 / dgw 2007-09-24 14:30:38 UTC
Thanks, Mr. Kattouw, that clarifies a lot. I thought new features were only for major releases, but I thought I'd ask anyway.

I wish I had Linux, but I'm on Windows, since this is just a homework computer from my school with a server, database, and PHP installed (I'm probably bending/breaking a rule, but MediaWiki is worth it ;) ). I'll go over the documentation for my text editor carefully to look for patching instructions, and if I don't find them, I'll either do the manual thing or look for a patch-supporting one. I'm pretty convinced that a developer's editor like Notepad++ will have patch support; I just have to find it.

And then I'll wipe Windows XP and install Linux. :P Just kidding. Though it's not a bad idea...
Comment 7 Platonides 2007-09-25 12:54:29 UTC
Patch for Windows: http://gnuwin32.sourceforge.net/packages/patch.htm
Comment 8 Voyagerfan5761 / dgw 2007-12-22 07:40:38 UTC
I'm reopening this bug because, now that I test the latest preview.js file, the Live Preview button seems to just do a normal preview. Something glitched...
Comment 9 Niklas Laxström 2007-12-22 20:22:56 UTC
Live preview is supposed to be like normal preview but without page loads because it uses ajax. Or do you mean something else?
Comment 10 Voyagerfan5761 / dgw 2007-12-22 20:29:36 UTC
(In reply to comment #9)
> Live preview is supposed to be like normal preview but without page loads
> because it uses ajax. Or do you mean something else?
> 

I wasn't clear enough, I guess. I mean it's actually behaving as if Live Preview just isn't enabled. The whole page reloads and action=edit in the URL changes to action=submit. If I go back to the code released with 1.11.0, it behaves properly, but then the text-chopping comes back.
Comment 11 Niklas Laxström 2009-02-28 19:20:10 UTC
The original bug is fixed. Live preview is not currently supported.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links