Last modified: 2007-11-15 03:34:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11315 - Anonymous users' signatures should link to contribs page
Anonymous users' signatures should link to contribs page
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-09-12 21:40 UTC by Gurch
Modified: 2007-11-15 03:34 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch (869 bytes, patch)
2007-09-30 16:14 UTC, Gurch
Details
patch (907 bytes, patch)
2007-09-30 17:31 UTC, Gurch
Details
patch (948 bytes, patch)
2007-09-30 21:44 UTC, Gurch
Details
Updated patch, includes signature pattern in mediawiki namespace and different behavior for anon and registered users (1019 bytes, patch)
2007-11-13 18:53 UTC, CBM
Details

Description Gurch 2007-09-12 21:40:22 UTC
Anonymous users almost never have userpages, especially on those wikis where they are not allowed to create non-talk pages. Since an anonymous user is just an IP address, the concept of an "anonymous user page" is rather a strange one.

Anyway, right now when an anonymous user signs a comment, the resulting link points to their user page; this almost never exists and thus shows a not-very-useful red link to where their userpage would be.

The user's talk page, on the other hand, is far more likely to exist, and their contributions list is, if they have signed an edit, guaranteed to contain at least one item. 

Linking anonymous users' signatures to either of these things would be much more useful than the current arrangement. It would also somewhat parallel the situation with page histories, where anonymous users have a contributions link in the place a registered user has a user page link.
Comment 1 Gurch 2007-09-23 21:43:09 UTC
After some thought, the contribs page rather than the talk page is the most logical and least confusing place to link it to (to be consistent with page histories). Though perhaps a separate talk link could be added as well, like many registered users do with their signatures.

Anyway, the important thing is that anything other than the current situation is vastly preferable...
Comment 2 Gurch 2007-09-30 16:14:54 UTC
Created attachment 4188 [details]
patch
Comment 3 Gurch 2007-09-30 17:31:46 UTC
Created attachment 4189 [details]
patch

oops, ignore that previous one
Comment 4 Rob Church 2007-09-30 21:18:04 UTC
SpecialPage::getTitleFor() returns a Title object, not a string.
Comment 5 Gurch 2007-09-30 21:28:12 UTC
It does? See, that's how little MediaWiki I know. :/

I'll go find how to turn that into a string, then... or you could always just fix it. :)
Comment 6 Gurch 2007-09-30 21:44:08 UTC
Created attachment 4190 [details]
patch

This one might work. though I'm not making any guarantees in that respect.

Remind me never to try to fix things myself again. Or at least to learn PHP first (it's a bit like JavaScript only with $s, right?)
Comment 7 CBM 2007-11-13 18:40:17 UTC
*** Bug 11913 has been marked as a duplicate of this bug. ***
Comment 8 CBM 2007-11-13 18:53:02 UTC
Created attachment 4335 [details]
Updated patch, includes signature pattern in mediawiki namespace and different behavior for anon and registered users

Here is an updated patch that includes the patch from 11913. It is tested and works on my mediawiki install. 

Both MediaWiki:signature and MediaWiki:signature-ip need to default to "[[$1|$2]] ([[$3|$4]])" to make this work; I'm not too familiar with the language files.
Comment 9 Roan Kattouw 2007-11-13 20:07:58 UTC
(In reply to comment #8)
> Both MediaWiki:signature and MediaWiki:signature-ip need to default to
> "[[$1|$2]] ([[$3|$4]])" to make this work; I'm not too familiar with the
> language files.

To clarify:
$1 is the name of your userpage ("User:Catrope")
$2 is your username ("Catrope")
$3 is the name of your talk page ("User talk:Catrope")
$4 is MediaWiki:Talk ("Talk", "Overleg", "Diskussion", whatever)

Effectively, this means the default sig format will change from <Catrope> to <Catrope> (<Talk>). Since this is not a big deal, I'm gonna commit it anyway (I will have to copypaste the same line to 100+ language files. Ah well...)

Comment 10 Roan Kattouw 2007-11-13 20:32:49 UTC
Fixed in r27473. I didn't have to change all 100+ language files, thank God for fallbacks.
Comment 11 CBM 2007-11-14 02:09:35 UTC
Ironically, MediaWiki:Talk is 'Discussion' on English wikipedia. But the project can override this by editing the signature message. I just wanted to have something acceptable and internationalized as the default. 
Comment 12 Roan Kattouw 2007-11-14 13:41:05 UTC
(In reply to comment #11)
> Ironically, MediaWiki:Talk is 'Discussion' on English wikipedia.
It uses MediaWiki:Talkpagelinktext, which is 'Talk' on ENWP. My mistake.
Comment 13 Brion Vibber 2007-11-15 03:34:28 UTC
Changed a bit in r27512 to simplify a bit and make the messages more flexible -- the link destination is no longer hardcoded.

Additionally I've taken out the (talk) links for the moment, but they can be trivially re-added in the message.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links