Last modified: 2014-01-03 15:55:22 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11289 - Media Descriptions Imported From Commons
Media Descriptions Imported From Commons
Status: RESOLVED WONTFIX
Product: MediaWiki extensions
Classification: Unclassified
OggHandler (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/Image:Ba...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-09-11 15:35 UTC by Christian Neubauer
Modified: 2014-01-03 15:55 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Christian Neubauer 2007-09-11 15:35:23 UTC
On this page, the file description imported from commons includes a link to an .ogg file.  This creates a control to play the file but the control causes a javascript error when clicked.
Comment 1 Brion Vibber 2007-09-11 15:42:42 UTC
Error: wgOggPlayer is not defined
Source File: http://en.wikipedia.org/wiki/Image:Bassoon-octaves-spectrogram.png
Line: 1

Looks like it's pulling the HTML of the description page, which includes a player via this link:
[[Image:Bassoon-technical-bflatoctaves.ogg]]

but the head scripts aren't included, so the OggPlayer.js doesn't get loaded.
Comment 2 Christian Neubauer 2007-10-05 17:29:32 UTC
Crappy workaround is to add:

if(strpos($this->mExtraDescription, 'wgOggPlayer') !== false && class_exists('OggHandler')) {
    OggHandler::setHeaders($wgOut);
}

to line 76 of ImagePage.php inside the if($this->mExtraDescription) block in the view function.

Other options:

1. OggHandler could attach to a hook in output page and checked for the existence of 'wgOggPlayer' in the text that's about to be outputted.
2. The wgOggPlayer javascript that's throwing the error could be wrapped in an if('wgOggPlayer') block.  This should probably be done anyway.  The control would then be useless in a situation like this but at least it wouldn't throw errors.
3. A new hook could be fired from ImagePage->view() or lower in the FileRepo code when a file description is imported from a foreign source which extensions could then catch.
Comment 3 Tim Starling 2008-10-06 07:16:46 UTC
(In reply to comment #2)
> 2. The wgOggPlayer javascript that's throwing the error could be wrapped in an
> if('wgOggPlayer') block.  This should probably be done anyway.  The control
> would then be useless in a situation like this but at least it wouldn't throw
> errors.

Did this in r41732. Ideally I'd like to have interwiki transclusion and commons description transclusion use a more information-rich interface than action=render. Something similar to a serialized ParserOutput would be good.
Comment 4 Andre Klapper 2013-07-30 10:25:57 UTC
The OggHandler extension is not under active development anymore. It is unlikely that there will be any further active development.

OggHandler has been superseded by TimedMediaHandler:

          http://www.mediawiki.org/wiki/Extension:TimedMediaHandler

Please use TimedMediaHandler instead.

Closing this report as WONTFIX as part of Bugzilla Housekeeping.

Please feel free to reopen this bug report in the future if either anyone takes the responsibility for active development of OggHandler again; or move this bug report from the "OggHandler" to the "TimedMediaHandler" component in Bugzilla if the same problem still happens when using TimedMediaHandler. Thanks.
Comment 5 Christian Neubauer 2013-12-06 16:11:00 UTC
I would actually consider this fixed since the functionality at the link in the original report now works just fine (thanks to TimedMediaHandler)...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links