Last modified: 2014-09-24 01:12:50 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11243 - Show images on image description page previews
Show images on image description page previews
Status: REOPENED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.12.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-reviewed
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-09-08 22:16 UTC by Roland Hieber
Modified: 2014-09-24 01:12 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
EditPage.php shows images when previewing image descriptions (335 bytes, patch)
2008-01-21 10:23 UTC, Roland Hieber
Details

Description Roland Hieber 2007-09-08 22:16:01 UTC
This would be useful especially when editing the image description, adding or correcting details which are visible on the picture. Furthermore, I don't understand, why the image isn't being displayed at all in the preview...
Comment 1 Raimond Spekking 2007-09-12 18:37:04 UTC
Done with r25819.
Comment 2 Brion Vibber 2007-09-13 18:37:01 UTC
Reverted in r25831.

This made the preview *less* like the actual page display than before. Image description pages don't have a right-floated gallery with a thumbnail of the image on them.
Comment 3 Bertrand GRONDIN 2008-01-20 13:57:31 UTC
This problem persists on mediawiki. See by example : http://fr.vikidia.org/index.php/Image:Vikidia_16px.gif

If you use [[Image:Vikidia 16px.gif|left]] or another parameters, mediawiki doesn't display it. It's a really problem. 
Comment 4 Brion Vibber 2008-01-21 08:54:46 UTC
I don't understand how comment #3 relates to the bug as described.
Comment 5 Bertrand GRONDIN 2008-01-21 09:26:15 UTC
it's a mistake. See now bug #12719.
Comment 6 Roland Hieber 2008-01-21 09:41:21 UTC
But I don't understand why the bug status has been set to RESOLVED? As far as I can see, the enhancement has not been implemented yet to MediaWiki.
Comment 7 Bertrand GRONDIN 2008-01-21 09:43:37 UTC
bug was fixed originally par Brion. I reopened this one one day ago. It was a mistake from me.
Comment 8 Roland Hieber 2008-01-21 10:23:09 UTC
Created attachment 4565 [details]
EditPage.php shows images when previewing image descriptions

Anyways, I tried to use the ImagePage::openShowImage function, don't know how good it works, but as I tested it, it looked as I expected.
Comment 9 User:Docu 2010-03-14 09:12:43 UTC
Maybe this could be done by editing some interface message used on preview?
Comment 10 User:Docu 2010-03-14 09:17:09 UTC
Maybe this could be done by editing some interface message.
Comment 11 User:Docu 2010-08-29 18:06:57 UTC
The interface message seems to be "MediaWiki:Previewnote", e.g. [[w:MediaWiki:Previewnote]] or [[Commons:MediaWiki:Previewnote]]

Commons uses now uses 

{{#ifeq:{{NAMESPACE}}|{{ns:6}}|[[File:{{PAGENAME}}|frameless|none]]}}

See http://commons.wikimedia.org/w/index.php?title=MediaWiki:Previewnote&action=edit

It's not great, but it works and it helps if one edits too many similar images at the same time.
Comment 12 p858snake 2011-04-30 00:09:51 UTC
*Bulk BZ Change: +Patch to open bugs with patches attached that are missing the keyword*
Comment 13 Sumana Harihareswara 2011-11-10 06:59:35 UTC
Roland, thank you for your patch, and I'm sorry for the wait.  Can you check whether the original bug is still reproducible?  And, if so, can you produce your diff in unified diff format and attach it to this bug?  Thanks.
Comment 15 Saibo 2012-06-27 20:17:15 UTC
Please insert it to the standard page preview (don't forget to make the image accessible via an id to enable users to manipulate it via css/JS) and insert a pre-checked checkbox into [[Special:Preferences#mw-prefsection-editing]] to provide an easy option to disable it per user if someone does not like it. Maybe also add a textbox there to specify a thumbnail  size (like it exists for normal page thumbnails).
Comment 16 Bawolff (Brian Wolff) 2012-06-29 11:57:43 UTC
>insert a
>pre-checked checkbox into [[Special:Preferences#mw-prefsection-editing]] to
>provide an easy option to disable it per user if someone does not like it.

Is there any reason why someone would not like such a thing? (prefs are evil and all)
Comment 17 Krinkle 2012-06-29 11:59:45 UTC
Lets not make this silly thing a preference. Not showing the image is an incorrect preview, and commons has done it locally for years.
Comment 18 Saibo 2012-06-29 23:35:44 UTC
(In reply to comment #17)
> Lets not make this silly thing a preference. Not showing the image is an
> incorrect preview, and commons has done it locally for years.

Not really. It is just in English interface for years. And for some months in German. Not in other langs. 

Why I say pref? Because hiding via gadgets is unintuitive and causes page jumping (in case of JS). Also gadgets do not help smaller wikis - they cannot maintain / program them.  Are prefs bad somehow?
Comment 19 Saibo 2012-06-29 23:39:13 UTC
(In reply to comment #16)
> Is there any reason why someone would not like such a thing? (prefs are evil
> and all)

There is: it is just not needed if you just want to edit the text. It consumes vertical space which forces you to scroll to see the stuff which you did want to see (since you've edited it!). Yes, the image is useful, if you were editing the description and want to have a quick look at the image again (was the dog on the left or right side?). Currently I see it - but I think I would rather have it not shown by default (maybe just css hidden and shown by a click on a small link/button at its place.
Comment 20 Saibo 2012-06-30 00:43:01 UTC
I am trying out that currently (only problem is that the show/hide trigger is also shown before a preview is done):
* https://commons.wikimedia.org/?title=User:Saibo/common.css&diff=73495526&oldid=70916280
* https://commons.wikimedia.org/?title=User%3ASaibo%2Fmonobook.js&diff=73496275&oldid=73052144
Comment 21 Krinkle 2012-06-30 03:44:27 UTC
(In reply to comment #18)
> (In reply to comment #17)
> > Lets not make this silly thing a preference. Not showing the image is an
> > incorrect preview, and commons has done it locally for years.
> 
> Not really. It is just in English interface for years. And for some months in
> German. Not in other langs. 
> 

So, commons has done it locally for years. Which languages it included is another, it was highly visible for many users.

> Why I say pref? Because hiding via gadgets is unintuitive and causes page
> jumping (in case of JS). Also gadgets do not help smaller wikis - they cannot
> maintain / program them.  Are prefs bad somehow?

When coming down to pref vs. gadget, then this should be a pref. The main point is, this should not be a pref. Nobody should even want to care about this, and I am sure that if nobody points it out, nobody will notice. Its just part of the interface. Hiding every single thing that some users may not need at some points in time through a preference is crazy.

That's not to say it can't be discussed. Feel free to provide rational reasons why it should not be displayed (ideally reasons that real users have expressed on Commons that didn't want the image in the preview).
Comment 22 Saibo 2012-06-30 23:27:05 UTC
(In reply to comment #21)
> The main point is, this should not be a pref. 
Sorry, I will not follow that anymore if I get no real answer. Do it or do it not somehow and make MediaWiki not better, if you want to.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links