Last modified: 2010-05-15 15:33:21 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T3124, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 1124 - <gallery> syntax is not valid xhtml 1.0


Summary:	<gallery> syntax is not valid xhtml 1.0

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	1.4.x
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	http://commons.wikimedia.org/wiki/Acr...
Whiteboard:
Keywords:	patch

Depends on:
Blocks:	html
	Show dependency tree / graph

Reported:	2004-12-18 02:40 UTC by bdk
Modified:	2010-05-15 15:33 UTC (History)
CC List:	1 user (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Patches ImageGallery.php for HEAD (1.66 KB, patch) 2004-12-27 16:59 UTC, Zigger	Details
Patches ImageGallery.php for REL1_4 (1.67 KB, patch) 2004-12-27 17:00 UTC, Zigger	Details
Proposed fix to ImageGallery.php (3.65 KB, text/plain) 2004-12-28 06:44 UTC, ejsanders	Details
Show Obsolete (2) Add an attachment (proposed patch, testcase, etc.)

Description bdk 2004-12-18 02:40:43 UTC

gallery syntax is parsed in a wrong way, the problem exists for every gallery on 
commons at the moment; compare these validation results http://validator.w3.org/
check?uri=http%3A%2F%2Fcommons.wikimedia.org%2Fwiki%2FAcropolis for example

Comment 1 Brion Vibber 2004-12-18 02:41:24 UTC

Added blocking on XHTML tracking bug 209

Comment 2 Zigger 2004-12-27 16:59:23 UTC

Created attachment 183 [details]
Patches ImageGallery.php for HEAD

Comment 3 Zigger 2004-12-27 17:00:00 UTC

Created attachment 184 [details]
Patches ImageGallery.php for REL1_4

Comment 4 ejsanders 2004-12-28 06:44:39 UTC

Created attachment 185 [details]
Proposed fix to ImageGallery.php

Image galleries are now valid xhtml, and look a bit more like the current image
boxes. Positioning is done with calculated padding to achieve vertical
alignment as XHTML/CSS can't do vertical alignment (beyond aligning inline
images against their text, it really is impossible). The other fixes still use
the height property of TD , which is only accepted in XHTML 1.0 Transistional,
not Strict.

Sorry, but I don't know how to do diffs :(.

Comment 5 Patrick-Emil Zörner 2005-01-04 15:22:07 UTC

On
[http://commons.wikimedia.org/wiki/Commons_talk:MediaWiki_1.4_upgrade#Galleries_not_valid_XHTML_1.0_trans.
commons] there is already a short discussion about this. First the attribute
valign="center" does not do anything at all (you could write foo="FU" instead)!
But the attribute "height" has an effect all major brwosers. This is a disaster
and the  reason why I reset the priority. --~~~~

Comment 6 Kai F. Lahmann 2005-01-04 15:47:05 UTC

<table height="XXpx"> is nonsence. What the browsers like is <table height="XX">
(without unit!!!). And what both, browsers AND HTML Spec like, is <table
style="height:XXpx;">.

Comment 7 JeLuF 2005-01-05 22:14:20 UTC

Fixed in CVS HEAD, based on patch provided by Ed Sanders.

ImageGallery.php, revision 1.15, and lots of CSS files.

Comment 8 JeLuF 2005-01-06 23:03:15 UTC

Fixed in REL1_4

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links