Last modified: 2008-02-06 09:06:30 UTC
Created attachment 4064 [details] Proposed patch Logging in on a foreign-language wiki could be problematic because even if you manually append &uselang=<whatever> to the URL, you'll see error messages in this wiki's default language. Here is the patch that fixes this problem.
ST47: You reviewed "need-review" from the keywords. Does this mean you reviewed it? If so, please add the keyword "reviewed".
Ahha! Have done so :)
Patch causes a redirect to a URL containing a blank "uselang" parameter; ditch $wgLoginLanguageSelector from the if conditions. Patch fails review.
(In reply to comment #3) > Patch causes a redirect to a URL containing a blank "uselang" parameter; ditch > $wgLoginLanguageSelector from the if conditions. > > Patch fails review. > heh, saw that one coming ;)
A second, very related issue, is that the success message from login does not pick up the user's language preferences, although the user is now logged in and so those preferences should be used. For example, my language on German wiki is English, but when I log in the 'login success' page does not use that setting. As soon as I leave that to go to another page, my language preferences are used.
A solution would be to set $wgLoginLanguageSelector = true; in localSettings.php It was set for the multi language projects Wikimedia Commons and Meta (at least). I do not know why it isn't set for all WMF wikis.
As mentioned in comment #6 I filed bug 12934 to set $wgLoginLanguageSelector for all WMF wikis. Other wikis could do this too -> closing this bug as WORKSFORME.
