Last modified: 2008-02-06 09:06:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11139 - Special:Userlogin should remember uselang
Special:Userlogin should remember uselang
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.11.x
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
http://en.wikipedia.org/wiki/Special:...
: patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-08-31 17:54 UTC by Max Semenik
Modified: 2008-02-06 09:06 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch (634 bytes, patch)
2007-08-31 17:54 UTC, Max Semenik
Details

Description Max Semenik 2007-08-31 17:54:34 UTC
Created attachment 4064 [details]
Proposed patch

Logging in on a foreign-language wiki could be problematic because even if you manually append &uselang=<whatever> to the URL, you'll see error messages in this wiki's default language. Here is the patch that fixes this problem.
Comment 1 Casey Brown 2007-09-01 00:09:36 UTC
ST47: You reviewed "need-review" from the keywords.  Does this mean you reviewed it?  If so, please add the keyword "reviewed".
Comment 2 Dan Collins 2007-09-01 00:10:56 UTC
Ahha! Have done so :)
Comment 3 Rob Church 2007-09-01 04:54:49 UTC
Patch causes a redirect to a URL containing a blank "uselang" parameter; ditch $wgLoginLanguageSelector from the if conditions.

Patch fails review.
Comment 4 Aaron Schulz 2007-09-01 07:24:56 UTC
(In reply to comment #3)
> Patch causes a redirect to a URL containing a blank "uselang" parameter; ditch
> $wgLoginLanguageSelector from the if conditions.
> 
> Patch fails review.
> 

heh, saw that one coming ;)
Comment 5 CBM 2007-11-05 15:24:12 UTC
A second, very related issue, is that the success message from login does not pick up the user's language preferences, although the user is now logged in and so those preferences should be used. For example, my language on German wiki is English, but when I log in the 'login success' page does not use that setting.  As soon as I leave that to go to another page, my language preferences are used. 
Comment 6 Raimond Spekking 2007-11-21 14:28:02 UTC
A solution would be to set 

   $wgLoginLanguageSelector = true;

in localSettings.php

It was set for the multi language projects Wikimedia Commons and Meta (at least). I do not know why it isn't set for all WMF wikis.
Comment 7 Raimond Spekking 2008-02-06 09:06:30 UTC
As mentioned in comment #6 I filed bug 12934 to set $wgLoginLanguageSelector for all WMF wikis.

Other wikis could do this too -> closing this bug as WORKSFORME.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links