Last modified: 2013-04-22 16:16:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 11056 - Closing bracket skipped in emailed links
Closing bracket skipped in emailed links
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Low enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
https://translatewiki.net/wiki/Thread...
:
Depends on:
Blocks: messages
  Show dependency treegraph
 
Reported: 2007-08-24 17:14 UTC by Quiddity
Modified: 2013-04-22 16:16 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Quiddity 2007-08-24 17:14:11 UTC
End brackets are misinterpreted as being part of the message, not the link, in Thunderbird email (and possibly others?). Hence links appear broken when clicked. e.g.:
http://en.wikipedia.org/wiki/Sigil_(computer_programming
http://en.wikipedia.org/wiki/British_Isles_(terminology

I suggest some sort of check for closingbrackets. Perhaps when an open bracket without a closing partner is found?
Comment 1 Rob Church 2007-08-24 17:43:41 UTC
There's really very little we can do about this. An automatic check may sound cute, but would conflict if you actually wanted the title without the closing parenthesis.

I would personally consider this a bug in the mail application, although this may be due to our "unescaping" of closing parentheses in the general URL-encoder (the line which does this *is* commented with something similar to "is this safe?")
Comment 2 Brion Vibber 2007-08-24 17:53:24 UTC
( and ) are perfectly legitimate URL characters; like other allowed punctuation chars such as ".", though, they can play havoc with software which tries to extract URLs out of unformatted prose text.

The problem is that this is a perfectly legimitate url:

  http://example.com/something.html.

but usually in prose text if you see something this:

  You can find more info at http://example.com/something.html.

that final '.' is intended as just punctuation for the prose text, not as part of the URL.

There are a couple of possible ways to plan for and work around this. One would be to special-case URLs that are placed into outgoing email, by looking for common punctuation chars and re-escaping them differently.

Another would be to do so for _all_ the URLs we generate, but that gives me the willies. ;)

A special-case for email would at least avoid breaking anything else.

Before doing any code, I'd recommend doing a quick survey of various e-mail clients to see how they handle some cases with trailing and embedded punctuation chars.
Comment 3 Nemo 2012-07-26 14:01:01 UTC
Isn't this fixed by simply putting URLs between <> as our messages mostly do (but not all of them)?
Comment 4 Nemo 2012-09-19 14:39:16 UTC
Gerrit change #24291.
Comment 5 Siebrand Mazeland 2012-10-24 17:42:42 UTC
Was merged. Thanks.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links