Last modified: 2008-08-04 04:00:59 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T13035, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 11035 - Special:Search should have descriptive <title>
Special:Search should have descriptive <title>
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Search (Other open bugs)
1.12.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2007-08-23 03:34 UTC by Dan Jacobson
Modified: 2008-08-04 04:00 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Dan Jacobson 2007-08-23 03:34:32 UTC 
Gentlemen, Google puts the item searched for in the <title>
$ GET http://www.google.com.tw/search?q=bg4wip | perl -nwe 's/.*(<title>)/$1/&&print'
<title>bg4wip - Google</title>

Why of course, how else could one pick different searches out of their browser's history?

Now we turn to MediaWiki. It's just the same
<title>Search results SITENAME<title>, no matter what string you search for.
Comment 1 Raimond Spekking 2007-09-24 13:22:26 UTC 
Done with r26071.
Comment 2 Brion Vibber 2007-09-24 18:41:28 UTC 
Reverted as it was clearly never tested. Title text is double-escaped, smearing bug ugly &quot; everywhere.
Comment 3 Raimond Spekking 2007-09-24 20:22:32 UTC 
Fixed with r26084.
Comment 4 Brion Vibber 2007-09-24 21:12:17 UTC 
Reverted again; while now functional, it just plain looks wrong since the text is duplicated between title and subtitle.
Comment 5 Raimond Spekking 2007-09-24 21:19:37 UTC 
Giving up for the moment :-(

Removal of subtitle would be a bad solution too, as it "includes by default a link to the search text as a page and in some live installations has been customized with additional links" (per Brion)
Comment 6 Danny B. 2008-04-12 00:32:04 UTC 
Bug 13708 related.
Comment 7 Robert Stojnic 2008-08-02 15:02:43 UTC 
Another shot at this in r38440. I believe the original poster was referring only to the HTML title, so that the title-subtitle duplication is avoided.
Comment 8 Brion Vibber 2008-08-04 04:00:59 UTC 
Thanks, Robert -- looks like a good compromise! Window/tab/bookmark title is now sane, and we've still got our nice clicky subtitle.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links