Last modified: 2007-08-02 06:13:00 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 10773 - CSS not included in page with SyntaxHighlight GeSHi
CSS not included in page with SyntaxHighlight GeSHi
Product: MediaWiki extensions
Classification: Unclassified
SyntaxHighlight (GeSHi) (Other open bugs)
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2007-08-02 04:53 UTC by Kenny Root
Modified: 2007-08-02 06:13 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

First try at including the CSS in the Wiki page. (463 bytes, patch)
2007-08-02 04:53 UTC, Kenny Root

Description Kenny Root 2007-08-02 04:53:30 UTC
Created attachment 3965 [details]
First try at including the CSS in the Wiki page.

The line in SyntaxHighlight_GeSHi.php:
$wgHooks['ShowRawCssJs'][] = 'SyntaxHighlight_GeSHi::viewHook';

no longer works (at least in MediaWiki 1.10) to include the CSS in the resulting Wiki page. The result is that the span tags are inserted correctly into the page, but no CSS style information is included.
Comment 1 Rob Church 2007-08-02 06:12:42 UTC
1. The `ShowRawCssJs` hook has never existed in the 1.10 branch
2. This hook is nothing to do with the parser hook which deals with the <source> tag
3. CSS isn't embedded into the page at the parser output location, but rather, passed to the ParserOutput as a "head item" (concept introduced in 1.10) which is then passed to the OutputPage when the page is viewed

I can confirm that <source> works as expected in both 1.10.x and 1.11alpha, and that in the latter, highlighting on eligible CSS and JavaScript pages works too.

Note You need to log in before you can comment on or make changes to this bug.