Last modified: 2011-04-11 01:17:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T12727, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 10727 - Create the group "test-sysop" for the Wikimedia Incubator
Create the group "test-sysop" for the Wikimedia Incubator
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Normal enhancement with 8 votes (vote)
: ---
Assigned To: Nobody - You can work on this!
http://incubator.wikimedia.org/wiki/I...
: shell
Depends on:
Blocks: incubator
  Show dependency treegraph
 
Reported: 2007-07-28 01:29 UTC by Casey Brown
Modified: 2011-04-11 01:17 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Casey Brown 2007-07-28 01:29:12 UTC
Could you please set it up to allow bureaucrats to desysop users in addition to sysopping them?  This would help us in enforcing our administrator policy, [[incubator:Incubator:Administrators]]: Test administrators will be desysopped after a year or after a domain request for their langauge is completed. If the request is successful, they will automatically be sysopped at their new wiki. (and other bits)

It does not matter if this is done (if ever) with:

1. http://www.mediawiki.org/wiki/Extension:Desysop or
2. A better solution would be to set $wgAddGroups, $wgRemoveGroups etc. there so
bureaucrats can just do it themselves, using Special:Userrights. (suggested by Rob)

Thanks.
Comment 1 Robin Pepermans (SPQRobin) 2007-07-28 10:03:50 UTC
Yes, this would be really useful for Incubator. Desysopping will happen regularly.
Comment 2 Victor Vasiliev 2007-08-25 16:19:36 UTC
I propose to make seperate flag for test admins, because globally-elected sysops (not test sysops) should  be only desysoped by stewards. Also, according to incubator policy, test admins are not allowed to edit interface
Comment 3 Casey Brown 2007-08-25 19:25:47 UTC
(In reply to comment #2)
> I propose to make seperate flag for test admins, because globally-elected
> sysops (not test sysops) should  be only desysoped by stewards. Also, according
> to incubator policy, test admins are not allowed to edit interface
> 

It really doesn't matter which, it may be easiest to just install Extension:Desysop.  But, I'll look into the other one later (have to go right now, if need be, I'll attach something).
Comment 4 Casey Brown 2007-08-25 20:50:57 UTC
The following should work:
$wgGroupPermissions['test-admin']['delete'] = true;
$wgGroupPermissions['test-admin']['undelete'] = true;
$wgGroupPermissions['test-admin']['deletedhistory'] = true;
$wgGroupPermissions['test-admin']['block'] = true;
$wgGroupPermissions['test-admin']['blockemail'] = true;
$wgGroupPermissions['test-admin']['rollback'] = true;
$wgGroupPermissions['test-admin']['editinterface'] = false;

...and we'll probably need:
$wgGroupPermissions['bureaucrat']['userrights'] = true;
Comment 5 MF-Warburg 2007-08-26 09:08:14 UTC
we'll also need
$wgRemoveGroups['bureaucrat'] = array( 'test-admin', );
and maybe
$wgAddGroups['bureaucrat'] = false;
Comment 6 Victor Vasiliev 2007-08-26 19:53:37 UTC
>we'll also need
>$wgRemoveGroups['bureaucrat'] = array( 'test-admin', );
>and maybe
>$wgAddGroups['bureaucrat'] = false;

I think it should be following:
$wgAddGroups['bureaucrat'] = array( 'test-admin', 'sysop', 'bureaucrat', 'bot' );
$wgRemoveGroups['bureaucrat'] = array( 'test-admin', 'bot');

Also Makesysop and Makebot must be disabled.

Test admins also need protect right, don't they?
Comment 7 Casey Brown 2007-08-26 19:55:51 UTC
(In reply to comment #6)
> >we'll also need
> >$wgRemoveGroups['bureaucrat'] = array( 'test-admin', );
> >and maybe
> >$wgAddGroups['bureaucrat'] = false;
> 
> I think it should be following:
> $wgAddGroups['bureaucrat'] = array( 'test-admin', 'sysop', 'bureaucrat', 'bot'
> );
> $wgRemoveGroups['bureaucrat'] = array( 'test-admin', 'bot');
> 
> Also Makesysop and Makebot must be disabled.
> 
> Test admins also need protect right, don't they?
> 

Yeah, I forgot that one :-D but I think your 'crat array's work better. :-)
Comment 8 Casey Brown 2007-09-02 02:56:48 UTC
Changing bug name to reflect the current solution. :-)
Comment 9 Robin Pepermans (SPQRobin) 2007-09-02 18:43:02 UTC
I changed "test-admin" to "test-sysop" because an administrator also calls "sysop" and not "admin".

(In reply to comment #6)
> Test admins also need protect right, don't they?
> 

This is not necessary, protecting pages happens rarely. And we have enough admins to protect a page, if it is needed.
Comment 10 Casey Brown 2007-09-02 21:03:19 UTC
(In reply to comment #9)
> I changed "test-admin" to "test-sysop" because an administrator also calls
> "sysop" and not "admin".
> 
Okay, but keep in mind that if the group is created we should be able to alter how it shows up in the MediaWiki pages.

> (In reply to comment #6)
> > Test admins also need protect right, don't they?
> > 
> 
> This is not necessary, protecting pages happens rarely. And we have enough
> admins to protect a page, if it is needed.
> 

It wouldn't be too much of a hassle to add that as well, but you're right, they don't need it completely. :-)
Comment 11 Robin Pepermans (SPQRobin) 2007-09-15 11:59:15 UTC
So here is the code to make it easier, because the code was divided over a few comments.

A developer has to disable the extensions Makebot and Makesysop, and has to add this code to LocalSettings.php:

# Create the group "test-sysop"
$wgGroupPermissions['test-sysop']['delete'] = true;
$wgGroupPermissions['test-sysop']['undelete'] = true;
$wgGroupPermissions['test-sysop']['deletedhistory'] = true;
$wgGroupPermissions['test-sysop']['block'] = true;
$wgGroupPermissions['test-sysop']['blockemail'] = true;
$wgGroupPermissions['test-sysop']['rollback'] = true;
$wgGroupPermissions['test-sysop']['protect'] = false;

# A bureaucrat is able to add and remove this right
$wgGroupPermissions['bureaucrat']['userrights'] = true;
$wgAddGroups['bureaucrat'] = array( 'test-sysop', 'bot', 'sysop', 'bureaucrat' );
$wgRemoveGroups['bureaucrat'] = array( 'test-sysop', 'bot' );
Comment 12 Casey Brown 2007-09-16 18:23:39 UTC
(In reply to comment #11)
> A developer has to disable the extensions Makebot and Makesysop,

JeLuF tells me that Makesysop & makebot can't be disabled, because they are global extensions for the WM projects.
Comment 13 Victor Vasiliev 2007-09-17 11:18:39 UTC
(In reply to comment #12)
> (In reply to comment #11)
> > A developer has to disable the extensions Makebot and Makesysop,
> 
> JeLuF tells me that Makesysop & makebot can't be disabled, because they are
> global extensions for the WM projects.
> 

That's a problem, because Makesysop and $wgAddGroup are incompatible
Comment 14 MF-Warburg 2007-09-17 13:08:59 UTC
Yes, but when we bureaucrats then would go to Special:Makesysop but see the form from Special:Userrights and there we can also give sysop rights. Where's the problem?
Comment 15 Victor Vasiliev 2007-09-17 13:11:05 UTC
(In reply to comment #14)
> Yes, but when we bureaucrats then would go to Special:Makesysop but see the
> form from Special:Userrights and there we can also give sysop rights. Where's
> the problem?
> 

AFAIR MakeSysop doesn't understand $wgAddGroup and $wgRemoveGroup, so bureaucrats will get stewards' rights.
Comment 16 MF-Warburg 2007-09-17 13:41:25 UTC
I just tested it with MediaWiki 1.11.0rc1 and it worked (I could give sysop, test-sysop etc. rights as bureaucrat, but I couldn't add groups like checkuser, what only stewards can do).
Comment 17 Victor Vasiliev 2007-09-18 14:25:04 UTC
(In reply to comment #16)
> I just tested it with MediaWiki 1.11.0rc1 and it worked (I could give sysop,
> test-sysop etc. rights as bureaucrat, but I couldn't add groups like checkuser,
> what only stewards can do).
> 

And what about crosswiki functions? I wrote a bug about disabling it
Comment 18 MF-Warburg 2007-09-19 15:42:45 UTC
I didn't test.
Comment 19 Robin Pepermans (SPQRobin) 2007-09-22 18:36:59 UTC
To the developers: It is tested, it works, so please add this right as explained on comment #11 (except disabling those extensions because it isn't possible)
Thank you.
Comment 20 MF-Warburg 2007-12-10 16:06:39 UTC
This will work (also disabling extensions is not required):

$wgGroupPermissions['bureaucrat']['makesysop']=false; // disallow access to the crosswiki userrights page Special:Makesysop
$wgGroupPermissions['bureaucrat']['userrights']=true; // allow to use non-crosswiki Special:Userrights
$wgAddGroups['bureaucrat'] = array( 'test-admin', 'sysop', 'bureaucrat', 'bot' );
$wgRemoveGroups['bureaucrat'] = array( 'test-admin', 'bot');

$wgGroupPermissions['test-admin']['delete'] = true;
$wgGroupPermissions['test-admin']['undelete'] = true;
$wgGroupPermissions['test-admin']['deletedhistory'] = true;
$wgGroupPermissions['test-admin']['block'] = true;
$wgGroupPermissions['test-admin']['blockemail'] = true;
$wgGroupPermissions['test-admin']['rollback'] = true;
$wgGroupPermissions['test-admin']['editinterface'] = false;
Comment 21 Robin Pepermans (SPQRobin) 2007-12-10 17:01:01 UTC
Please use "test-sysop" (not "test-admin") for consistency with "sysop".
Comment 22 Robin Pepermans (SPQRobin) 2007-12-28 10:35:44 UTC
Because of a change in bug 11645, the code is different:

'groupOverrides' => array(
    'incubatorwiki' => array( 'test-sysop' => array(
        'delete' => true,
        'undelete' => true,
        'deletedhistory' => true,
        'block' => true,
        'blockemail' => true,
        'rollback' => true, )
     ),
),

'wgAddGroup' => array(
    'incubatorwiki' => array(
        'bureaucrat' => array( 'test-sysop', 'sysop', 'bureaucrat', 'bot' ),
    ),
),

'wgRemoveGroup' => array(
    'incubatorwiki' => array(
        'bureaucrat' => array( 'test-sysop', 'bot' ),
    ),
),

This should be the right code, I hope I didn't write any mistakes.

Thank you.
Comment 23 JeLuF 2008-01-17 22:45:23 UTC
Done.
Comment 24 Casey Brown 2008-01-17 22:57:29 UTC
(In reply to comment #23)
> Done.
> 

Thank you soo much JeLuF! /me huggles :-D

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links