Last modified: 2007-08-27 17:04:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T12683, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 10683 - Urlencoded wikilinks work for normal links but not redirects
Urlencoded wikilinks work for normal links but not redirects
Product: MediaWiki
Classification: Unclassified
Redirects (Other open bugs)
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
Depends on:
  Show dependency treegraph
Reported: 2007-07-24 17:09 UTC by Platonides
Modified: 2007-08-27 17:04 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Platonides 2007-07-24 17:09:04 UTC
Comment 1 Rob Church 2007-08-01 01:46:08 UTC
Fixed in r24505.
Comment 2 Brion Vibber 2007-08-26 14:54:49 UTC
Caused a regression breaking redirects to pages with '+' in the title.

Fixed in r25161 to match parser inline link behavior.
Comment 3 Mike Dillon 2007-08-26 23:32:30 UTC
It looks like the fix made it so that leading colons will only be removed from links that contain a percent sign. This will break hard category redirects (which I realize have little value, but I've seen them around and it seems like a regression).
Comment 4 Brion Vibber 2007-08-27 17:04:12 UTC
I don't see any regression testing something like #redirect [[:Category:Tests]].

The skipped ltrim() call looks unecessary to me; Title::newFromText() does this anyway (via the secureAndSplit(); it would only have a non-null effect if we passed a different default namespace into newFromText().).

Note You need to log in before you can comment on or make changes to this bug.