Last modified: 2007-07-24 18:57:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T12672, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 10672 - Make Linker::doEditSectionLink protected instead of private
Make Linker::doEditSectionLink protected instead of private
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.11.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
http://svn.wikimedia.org/svnroot/medi...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2007-07-23 21:32 UTC by Christian Neubauer
Modified: 2007-07-24 18:57 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Christian Neubauer 2007-07-23 21:32:04 UTC 
In Linker.php there is a function called doEditSectionLink that creates edit links.  It supports some nice hooks for changing the value of the edit link, but doesn't allow for advanced modification like adding a comment link next to the edit link or changing the HTML of the edit link.

Since skins inherit from SkinTemplate which inherits from Skin which inherits from Linker, users could override this function in their skin.  However, the function is currently private which apparently prevents it from being overridden.  If it were protected instead of private the problem would be solved.
Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-07-23 21:40:29 UTC 
I agree, it should be protected.  Changed in r24342.
Comment 2 Christian Neubauer 2007-07-24 18:57:20 UTC 
Not exactly sure what I was talking about up there.  The hooks do allow you to completely customize the edit links but thanks anyway.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links