Last modified: 2011-03-13 18:06:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T12609, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 10609 - Remove redirects from AJAX Search results
Remove redirects from AJAX Search results
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
Search (Other open bugs)
unspecified
All All
: Lowest trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-07-16 22:17 UTC by Sergey Chernyshev
Modified: 2011-03-13 18:06 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Remove redirects from AJAX Search results (736 bytes, patch)
2007-07-16 22:17 UTC, Sergey Chernyshev
Details

Description Sergey Chernyshev 2007-07-16 22:17:23 UTC
Created attachment 3920 [details]
Remove redirects from AJAX Search results

AJAX Search functionality seems to return redirects as part of it's results.

See attached patch that checks page_is_redirect column to be 0.

From the first glance it seems that putting this restriction after page_title LIKE ... is better because indexes are on page_namespace followed by page_title, but I'm not sure if they are used that much with LIKE. Someone with better knowledge of MW db indexes, please check.
Comment 1 Brion Vibber 2007-07-17 14:02:06 UTC
We want to include redirects; that's one of the reasons they exist.
Comment 2 Sergey Chernyshev 2007-07-17 14:11:38 UTC
Yes, I understand your point - every name is worth keeping. It seems to be a problem with some other installations though - with setups where there are many misspelling redirects or other non-essential ones.

Maybe it should be configurable.
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-07-17 16:23:45 UTC
Misspelling redirects are there for a reason too.  If someone quickly types, on Wiktionary, "superce", then pauses, they should get "supercede" as an option even if it's a redirect to "supersede".  Because otherwise they'll say, hey, what's with this stupid dictionary not having the word I want?  Obviously that's just an example, but you see the point, I think.
Comment 4 Sergey Chernyshev 2007-07-17 16:30:22 UTC
Yes, exactly. For some projects it makes sense, but it doesn't for others. Check how many JRR Tolkiens are out there - maybe showing all of them doesn't make sense. Regular search on Wikipedia doesn't show them (but if user typed Tolkein, then it'll show Tolkien) it means that there are reasons for not showing redirects in search results on some projects.

I propose to have it configurable and I can probably create a patch for that.
Comment 5 Brion Vibber 2007-07-17 16:59:33 UTC
The ideal behavior in most cases would likely be to list the original in the result (perhaps with a little note that it was found via a redirect) -- and to only return _one_ result, rather than multiple matching redirects.
Comment 6 Sergey Chernyshev 2007-07-17 17:15:43 UTC
Yes, sounds reasonable. I'll see if I can do that.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links