Last modified: 2008-09-19 13:23:28 UTC
Created attachment 3875 [details]
Trivial fix for inclusion error in install.php
install.php causes a PHP inclusion error if the extension is not in the $IP/extensions directory. Patch is attached.
1) That would be a pretty broken system, with files in the wrong place. :)
2) Unspecified relative includes of this sort are extremely unreliable and should be avoided, as they frequently cause scripts to break when not run from a particular directory, and/or if the include path is being used straight (without the old hardcoding).
It's much preferable to use clear paths as they will continue to work when run from command line.
3) This install.php is, or will soon be, obsolete as the new system will run through the standard MW update.php.
Seems fixed, as install.php makes use of MW_INSTALL_PATH. In addition, I _believe_ CU now uses the normal update.php, as Brion indicated a year ago that it would.