Last modified: 2007-06-29 02:12:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 10400 - AJAX watch response message: $1 not subst'd in link
AJAX watch response message: $1 not subst'd in link
Status: RESOLVED WORKSFORME
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
1.11.x
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks: 6261
  Show dependency treegraph
 
Reported: 2007-06-28 16:42 UTC by AlexSm
Modified: 2007-06-29 02:12 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description AlexSm 2007-06-28 16:42:27 UTC
When AJAX Watch script gets successful response from server and displays it on top (the message template is taken from e.g. http://en.wikipedia.org/wiki/MediaWiki:Removedwatchtext ) the "$1" inside URL ("watch" / "unwatch") is not substituted for correct page name.
Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-06-28 16:59:00 UTC
The English Wikipedia's hacky workaround for bug 6261 is what's failing here.  I have no idea what's different about this particular case, but of course, the nature of hacks is to fail randomly.

Workaround: remove the link from the message text.  There's a watch/unwatch link at the top of the page, after all.  :)
Comment 2 AlexSm 2007-06-28 17:20:58 UTC
The "watch" / "unwatch" link there is still useful in case of fallback (not using AJAX).

If {{fullurl:...$1...}} is hacky, is there another "good" way to construct a link using $1 ?

If not, I guess I'll have to go and request the link to be removed.

Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-06-28 17:25:18 UTC
When not using AJAX, there should still be a watch/unwatch link at the top of the page (although it seems it's the wrong way around . . .).

It's not {{fullurl:$1}} that's hacky, it's putting it in a template to work around bug 6261.
Comment 4 AlexSm 2007-06-29 02:12:37 UTC
Well, you were right, we discussed and decided the link was redundant and even confusing (not using ajax watch), so it was removed. Marking as WORKSFORME if you don't mind.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links