Last modified: 2007-07-05 14:06:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 10390 - AJAX watch/unwatch reverts to english interface
AJAX watch/unwatch reverts to english interface
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
unspecified
All All
: Normal minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-06-28 10:35 UTC by Tisza Gergő
Modified: 2007-07-05 14:06 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tisza Gergő 2007-06-28 10:35:03 UTC
While the new AJAX watch/unwatch is really cool, it now changes the text of the tab to "watch" or "unwatch", instead of the localized version found in [[MediaWiki:Watch]] and [[MediaWiki:Unwatch]].
Comment 1 Niklas Laxström 2007-06-28 11:43:12 UTC
It mixes language dependent code with site wide JavaScript. The bug occurs when user interface language is different from content language or if the cached script has wrong translations.
What would be the proper place to include translated strings?
Comment 2 Brion Vibber 2007-06-28 15:40:53 UTC
The simplest thing would be to include them in a <script> within the primary page, similar to what we currently do for the table-of-contents show/hide link.

Alternately, we could deal better with the remote JS vars inclusion, adding cache-hash info onto the URL to ensure it contains relevant information.

Handling of 'uselang' params might also be considered.
Comment 3 Tim Starling 2007-07-05 14:06:43 UTC
Fixed in r23739. 

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links