Last modified: 2007-06-28 13:50:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T12388, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 10388 - Changing email address throws Exception due to bad return value from "logPrefsHook" (live hack)
Changing email address throws Exception due to bad return value from "logPref...
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
: shell
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-06-28 00:59 UTC by Tomasz G. Sienicki
Modified: 2007-06-28 13:50 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tomasz G. Sienicki 2007-06-28 00:59:18 UTC
Any attempt to change the email address in preferences results in the following error:

#0 /usr/local/apache/common-local/php-1.5/includes/SpecialPreferences.php(336): wfRunHooks('PrefsEmailAudit', Array)
#1 /usr/local/apache/common-local/php-1.5/includes/SpecialPreferences.php(117): PreferencesForm->savePreferences()
#2 /usr/local/apache/common-local/php-1.5/includes/SpecialPreferences.php(14): PreferencesForm->execute()
#3 /usr/local/apache/common-local/php-1.5/includes/SpecialPage.php(653): wfSpecialPreferences(NULL, Object(SpecialPage))
#4 /usr/local/apache/common-local/php-1.5/includes/SpecialPage.php(459): SpecialPage->execute(NULL)
#5 /usr/local/apache/common-local/php-1.5/includes/Wiki.php(203): SpecialPage::executePath(Object(Title))
#6 /usr/local/apache/common-local/php-1.5/includes/Wiki.php(45): MediaWiki->initializeSpecialCases(Object(Title), Object(OutputPage), Object(WebRequest))
#7 /usr/local/apache/common-local/php-1.5/index.php(89): MediaWiki->initialize(Object(Title), Object(OutputPage), Object(User), Object(WebRequest))
#8 /usr/local/apache/common-local/live-1.5/index.php(3): require('/usr/local/apac...')
#9 {main}
Comment 1 Tomasz G. Sienicki 2007-06-28 01:04:28 UTC
The error header is: "Invalid NULL return from broken hook logPrefsEmail". 
Comment 2 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-06-28 03:52:52 UTC
What wiki is this?
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-06-28 03:54:50 UTC
Never mind, confirmed on English Wikipedia.
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-06-28 04:05:15 UTC
I can't find any use of that hook anywhere in trunk.  Either I'm blind or this is a non-versioned hack of some sort.  If I had to guess I'd suspect it's something related to the recent password-cracking issue, with e-mail and password changes being privately logged.  Thus it presumably escaped the crackdown on improper returns just now.
Comment 5 Rob Church 2007-06-28 12:17:41 UTC
It appears to be a live hack. Bumping to shell attention.
Comment 6 Brion Vibber 2007-06-28 13:50:54 UTC
Fixed.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links