Last modified: 2007-09-10 05:40:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 10332 - Title->userCan( 'edit' ) may return false positive
Title->userCan( 'edit' ) may return false positive
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.10.x
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-06-22 06:23 UTC by Nick Jenkins
Modified: 2007-09-10 05:40 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Attaching a patch for this against r23108. I haven't applied it in case there's something bleedingly obvious that I am missing. (370 bytes, patch)
2007-06-22 06:23 UTC, Nick Jenkins
Details
Patch to fix this bug for all actions (751 bytes, patch)
2007-07-12 15:24 UTC, Jelte (WebBoy)
Details

Description Nick Jenkins 2007-06-22 06:23:53 UTC
Created attachment 3808 [details]
Attaching a patch for this against r23108. I haven't applied it in case there's something bleedingly obvious that I am missing.

In includes/Title.php, Title->userCan( 'edit' ) seems to always return true, even if the user has "$wgGroupPermissions['*']['edit'] = false;" in their LocalSettings.php .

This does not seem right, and causes the TalkHere extension to behave incorrectly (always shows an "Add comment" link, even when the user cannot add a comment).
Comment 1 Nick Jenkins 2007-07-11 08:44:40 UTC
Added in r23996, marked as resolved.
Comment 2 Jelte (WebBoy) 2007-07-12 15:24:51 UTC
Created attachment 3893 [details]
Patch to fix this bug for all actions

There are other actions (like 'delete') affected by this bug. This patch will fix this bug for all actions.
Comment 3 Andrew Garrett 2007-07-12 15:47:21 UTC
This will be fixed in my upcoming userCan changes, and I see little immense need to apply the patch before they are applied - seeing as it's a completeness issue rather than an actual software error.
Comment 4 Andrew Garrett 2007-09-10 05:40:57 UTC
Fixed a while ago.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links