Last modified: 2007-06-22 19:23:07 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 10326 - Clean up AJAX watch for production use
Clean up AJAX watch for production use
Product: MediaWiki
Classification: Unclassified
Interface (Other open bugs)
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Aryeh Gregor (not reading bugmail, please e-mail directly)
Depends on:
  Show dependency treegraph
Reported: 2007-06-21 17:39 UTC by Aryeh Gregor (not reading bugmail, please e-mail directly)
Modified: 2007-06-22 19:23 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Proposed patch (10.04 KB, patch)
2007-06-21 17:39 UTC, Aryeh Gregor (not reading bugmail, please e-mail directly)

Description Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-06-21 17:39:51 UTC
Created attachment 3803 [details]
Proposed patch

Ajax watch is a nice feature but potentially has some usability issues.  Primarily, it doesn't give any indication of what "watching" actually does.  I've mostly fixed that in the attached patch, but it still needs issues to be ironed out, such as:

* Treatment of weird page names.
* Links to the current page in watched/unwatched messages appear as redlinks or not depending on whether the page '$1' exists, not whether wgIsArticle is true or similar considerations.  As an alternative to the current method, things could be simplified by adding the appropriate message to generated per-page JS variables, or better yet by just returning it with the Ajax response, instead of trying to hack around with a generalized message in JS.
* The current method of handling multiple watch links is ugly and could be improved with some methods that would loop through all available watch links to do whatever needs to be done.
* Possibly the alert box could be prettified, but that isn't really necessary.  However, it would be a good idea to class it as "mw-watch-message" or something as well as ID'ing it, so that people could hide watch messages but still keep other JS messages that we might add in the future.

Comments are appreciated.  Once these changes are complete I intend to turn the feature on by default.
Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-06-22 17:37:42 UTC
Improved patch committed in r23233.
Comment 2 Brion Vibber 2007-06-22 19:23:07 UTC
Lookin' awesome!

Note You need to log in before you can comment on or make changes to this bug.