Last modified: 2011-11-29 19:59:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 10300 - Change JavaScript variables to constants.
Change JavaScript variables to constants.
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
General/Unknown (Other open bugs)
1.11.x
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-06-18 08:28 UTC by Łukasz Matysiak
Modified: 2011-11-29 19:59 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch for fixing bug. (808 bytes, patch)
2007-06-18 08:28 UTC, Łukasz Matysiak
Details

Description Łukasz Matysiak 2007-06-18 08:28:58 UTC
Created attachment 3799 [details]
Patch for fixing bug.

JavaScript variables generated by Skin::makeVariablesScript can be overwrited by user JavaScript code, or by Common.js (skinName.js).
This is bad because some ajax extensions might very depend on some of those variables. This apply essspecially to "skin" variable.
Comment 1 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-06-18 22:49:53 UTC
As far as I can determine, "const" is not part of the ECMAScript standard and is not supported by non-Mozilla browsers.  Is this incorrect?
Comment 2 Aaron Schulz 2007-06-18 23:04:36 UTC
(In reply to comment #1)
> As far as I can determine, "const" is not part of the ECMAScript standard and
> is not supported by non-Mozilla browsers.  Is this incorrect?
> 

http://developer.mozilla.org/en/docs/Core_JavaScript_1.5_Guide:Constants
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-06-18 23:09:28 UTC
I'm aware that Mozilla browsers support const.  Does IE?  Does Opera?  Do Safari, Konqueror, ...?
Comment 4 Aaron Schulz 2007-06-18 23:16:33 UTC
See the above link:

"const is a Mozilla-specific extension, it is not supported by IE or Opera."
Comment 5 Chad H. 2011-11-29 19:59:04 UTC
This is a browser-specific implementation, marking WONTFIX.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links