Last modified: 2007-06-17 08:26:14 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 10274 - generator=watchlist complains about gwlprop even if it's not set
generator=watchlist complains about gwlprop even if it's not set
Product: MediaWiki
Classification: Unclassified
API (Other open bugs)
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
  Show dependency treegraph
Reported: 2007-06-15 14:59 UTC by Roan Kattouw
Modified: 2007-06-17 08:26 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Fixes unjustified generator=watchlist gwlprop error (679 bytes, patch)
2007-06-15 14:59 UTC, Roan Kattouw

Description Roan Kattouw 2007-06-15 14:59:32 UTC
Created attachment 3781 [details]
Fixes unjustified generator=watchlist gwlprop error


<error code="gwlparams" info="gwlprop parameter may not be used in a generator">

while gwlprop wasn't set. This is because the code assumes the default for gwlprop (ids|title|flags), and then complains that it's not empty. Setting gwlprop to an empty value doesn't work either, so there is currently no way to use list=watchlist as a generator.

The attached patch fixes this by only throwing an error if gwlprop is not set to its default value. The downside of this is that


won't cause an error, but it won't affect the query result either.
Comment 1 Yuri Astrakhan 2007-06-17 08:11:17 UTC
Thanks for the report and the patch. I will allow gwlprop to be specified to be consistent and to simplify design.
Comment 2 Yuri Astrakhan 2007-06-17 08:25:33 UTC
Fixed in r23043
Comment 3 Yuri Astrakhan 2007-06-17 08:26:14 UTC
Oops, forgot to mark as fixed.

Note You need to log in before you can comment on or make changes to this bug.