Last modified: 2008-09-05 22:59:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 10261 - Reason for page protection should be displayed when editing/viewing source of a protected page
Reason for page protection should be displayed when editing/viewing source of...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.10.x
All All
: Normal enhancement with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-06-14 18:17 UTC by Max Semenik
Modified: 2008-09-05 22:59 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
proposed patch (3.87 KB, patch)
2007-06-14 18:17 UTC, Max Semenik
Details

Description Max Semenik 2007-06-14 18:17:09 UTC
Created attachment 3766 [details]
proposed patch

I made a patch that adds last protection log entry to edit page. The entire log is not needed because it will be too long for heavily-vandalized pages.
Comment 1 Rob Church 2007-06-14 19:43:47 UTC
Working off logs isn't the best approach here; the reason shown should be taken out of the protection table directly.

Showing log fragments without any explanation on the edit page is not a good idea; I'm also wary of complicating Article::showLogFragment().
Comment 2 Aaron Schulz 2007-06-14 19:45:48 UTC
(In reply to comment #1)
> Working off logs isn't the best approach here; the reason shown should be taken
> out of the protection table directly.
> 
> Showing log fragments without any explanation on the edit page is not a good
> idea; I'm also wary of complicating Article::showLogFragment().
> 

Perhaps you're schema change could add pr_reason. That would really help out SP:ProtectedPages. Currently I use a JS to scrap of the logs when checking it.
Comment 3 Rob Church 2007-06-14 20:36:30 UTC
(In reply to comment #2)
> Perhaps you're schema change could add pr_reason. That would really help out

Yes, I was thinking of that.
Comment 4 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-06-14 23:19:31 UTC
It might not make sense to take only the last as the reason.  It's not uncommon to have multiple consecutive protections that tweak the level up or down.  If pr_reason is added, perhaps it would be best to change the log message box to be prefilled with the existing comment, or have a separate box for it, or something.  Otherwise you'll get a fair number of pr_reasons like "forgot move protection" that don't really explain things by themselves, even though they're completely suitable as *log* comments.  Repurposing log comments for pr_reason is sort of messy.
Comment 5 Aaron Schulz 2007-06-15 02:47:28 UTC
Perhaps a good link to protection log for the page will do for now.
Comment 6 Aaron Schulz 2008-09-05 22:59:31 UTC
Done in r40509

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links