Last modified: 2010-05-15 15:32:57 UTC
if you limit in your preference image size viewed in [[Image:]] page the full
size url doesn't work as expected (see code ImagePage.php line 45 $url is
overwritten later when calling createThumb(). Patch joined. A side effect of
this patch is to not call createThumb() twice when image size is constrained by
both with and height. (Note this bug is unrelated to Brion recent fix about $max
et $height uninitialized when user preference about max image size is not set)
Bug easy to reproduce, set your user pref to 320*200, go to the above url click
on the link view full image size.
Created attachment 158 [details]
bug fix, side effect is to call createThumb() only one time.
Created attachment 161 [details]
158: bug fix, side effect is to call createThumb() at most one time
ignore the previous patch, I sent the wrong one...
Thanks for the fix!
Applied to HEAD and REL1_4. Deployed to commons.wikipedia.org. Verified.