Last modified: 2010-05-15 15:32:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T3024, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 1024 - limiting image size in user preference don't work as expected


Summary:	limiting image size in user preference don't work as expected

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Parser (Other open bugs)
Version:	1.4.x
Hardware:	PC Linux

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:	http://commons.wikimedia.org/wiki/Ima...
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2004-12-07 02:04 UTC by Philippe Elie
Modified:	2010-05-15 15:32 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
bug fix, side effect is to call createThumb() only one time. (1.97 KB, patch) 2004-12-07 02:06 UTC, Philippe Elie	Details
158: bug fix, side effect is to call createThumb() at most one time (1.75 KB, patch) 2004-12-07 04:46 UTC, Philippe Elie	Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Philippe Elie 2004-12-07 02:04:46 UTC

if you limit in your preference image size viewed in [[Image:]] page the full
size url doesn't work as expected (see code ImagePage.php line 45 $url is
overwritten later when calling createThumb(). Patch joined. A side effect of
this patch is to not call createThumb() twice when image size is constrained by
both with and height. (Note this bug is unrelated to Brion recent fix about $max
et $height uninitialized when user preference about max image size is not set)

Bug easy to reproduce, set your user pref to 320*200, go to the above url click
on the link view full image size.

Comment 1 Philippe Elie 2004-12-07 02:06:11 UTC

Created attachment 158 [details]
bug fix, side effect is to call createThumb() only one time.

Comment 2 Philippe Elie 2004-12-07 04:46:38 UTC

Created attachment 161 [details]
158: bug fix, side effect is to call createThumb() at most one time

ignore the previous patch, I sent the wrong one...

Comment 3 JeLuF 2004-12-07 21:33:40 UTC

Thanks for the fix!

Applied to HEAD and REL1_4. Deployed to commons.wikipedia.org. Verified.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links