Last modified: 2006-07-11 18:57:28 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 1023 - Language files are not XHTML-compliant.
Language files are not XHTML-compliant.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
unspecified
All All
: Normal normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch
Depends on: 2369
Blocks: 212
  Show dependency treegraph
 
Reported: 2004-12-07 01:27 UTC by Zigger
Modified: 2006-07-11 18:57 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
cleanup br-tags (patch for trunk, r14420) (22.92 KB, patch)
2006-05-27 10:15 UTC, Jimmy Collins
Details
cleanup one br-tag in SpecialEmailuser.php (trunk, r14420) (565 bytes, patch)
2006-05-27 10:28 UTC, Jimmy Collins
Details
cleanup br-tags (patch for trunk) (3.45 KB, patch)
2006-05-31 21:25 UTC, Jimmy Collins
Details
cleanup br-tags in SpecialRecentchanges.php and SpecialPreferences.php (1.41 KB, patch)
2006-05-31 21:33 UTC, Jimmy Collins
Details
cleanup br-tags (patch for trunk) (24.12 KB, patch)
2006-06-16 19:55 UTC, Jimmy Collins
Details
cleanup br-tags (patch for trunk) (24.88 KB, patch)
2006-06-24 23:26 UTC, Jimmy Collins
Details
cleanup br-tags (not i18n), patch for trunk (2.95 KB, patch)
2006-06-24 23:50 UTC, Jimmy Collins
Details
fix for hr- and br-tags in i18n (xhtml), patch for trunk (20.50 KB, patch)
2006-07-02 13:02 UTC, Jimmy Collins
Details

Description Zigger 2004-12-07 01:27:09 UTC
(split out from bug 1021)

The language files have a mixture of <br>, <br/>, and <br />.  The final form is
the preferred one for XHTML conformance.

They also have a mixture of wiki mark-up and HTML mark-up:
   <strong>text</strong>, <b>text</b>, '''text''',
   <em>text</em>, <i>text</i>, ''text''
Assuming that all messages are parsed, the final form is the preferred one.
Comment 1 Zigger 2004-12-07 01:31:06 UTC
Issues are in REL1_3, REL1_4 and HEAD.
Comment 2 Shane King 2004-12-07 13:21:01 UTC
I've made the change of <br> and <br/> to <br /> in 1.4 and HEAD (I didn't see
the point in bothering for 1.3, as checking this in takes forever over my poor
DSL uplink, and 1.4 will be current real soon now). I did this using sed and
then checking the results look reasonable. Hopefully doing this in an automated
manner is less error prone than doing it manually.

As for the <strong> and <em> stuff, I'm not 100% sure what text ends up going
through the parser, and I don't have time to check right now, so I left that
alone. If someone knows or wants to work it out, feel free to make the necessary
changes.
Comment 3 JeLuF 2004-12-07 21:54:25 UTC
Changing to "enhancement", since  <em> versus '' is a stylistic issue and not a bug.
Comment 4 Zigger 2004-12-08 12:49:56 UTC
Other XHTML issues in the 'googlesearch' message for most languages in most
branches:
upper case elements and attributes,
various attribute values are not quoted, and
missing " />" closer in "img" and "input" tags.

I've split out the markup inconsistency that's not XHTML-related to a new low
priority enhancement request.  See bug 1037
Comment 5 Zigger 2004-12-08 13:42:58 UTC
Sorry, the above comments about 'googlesearch' are probably a duplicate of bug 210
Comment 6 Rob Church 2005-12-15 18:05:18 UTC
I'd suggest passing all interface messages through the parser and ditching HTML
in them, myself. I would have thought we parsed most of them anyway, and don't
the tidy functions pick up stuff like <br> and <br/> ?
Comment 7 Jimmy Collins 2006-05-27 10:15:21 UTC
Created attachment 1841 [details]
cleanup br-tags (patch for trunk, r14420)

Here is a patch that replaces <br/>-tags to <br />-tags in some
MessagesXx.php-files (XHTML compliant)
Comment 8 Jimmy Collins 2006-05-27 10:28:11 UTC
Created attachment 1842 [details]
cleanup one br-tag in SpecialEmailuser.php (trunk, r14420)

Also found one <br>-tag in SpecialEmailuser.php
Comment 9 Niklas Laxström 2006-05-27 14:33:17 UTC
Both in r14421.
Comment 10 Jimmy Collins 2006-05-31 21:25:24 UTC
Created attachment 1870 [details]
cleanup br-tags (patch for trunk)

Here is another patch that replaces <br/>-tags to <br />-tags in MessagesSq.php
(XHTML compliant)
Comment 11 Jimmy Collins 2006-05-31 21:26:20 UTC
(In reply to comment #10)
> Here is another patch that replaces <br/>-tags to <br />-tags in MessagesSq.php
> (XHTML compliant)
<br> --> <br />
Comment 12 Jimmy Collins 2006-05-31 21:33:02 UTC
Created attachment 1871 [details]
cleanup br-tags in SpecialRecentchanges.php and SpecialPreferences.php
Comment 13 Jimmy Collins 2006-06-16 19:55:46 UTC
Created attachment 1970 [details]
cleanup br-tags (patch for trunk)

Here is another patch that replaces <br>-tags to <br />-tags (XHTML compliant)
in:
MessagesSq.php
Comment 14 Jimmy Collins 2006-06-16 19:59:37 UTC
(In reply to comment #13)
> Created an attachment (id=1970) [edit]
> cleanup br-tags (patch for trunk)
> 
> Here is another patch that replaces <br>-tags to <br />-tags (XHTML compliant)
> in:
- MessagesYi.php
- MessagesSk.php
- MessagesNl.php
- MessagesLa.php

Comment 15 Jimmy Collins 2006-06-16 20:02:07 UTC
Comment on attachment 1842 [details]
cleanup one br-tag in SpecialEmailuser.php (trunk, r14420)

already applied
Comment 16 Jimmy Collins 2006-06-24 23:26:04 UTC
Created attachment 2005 [details]
cleanup br-tags (patch for trunk)

The patch replaces <br>-tags to <br />-tags (XHTML compliant) in:
- languages/MessagesYi.php
- languages/MessagesSk.php
- languages/MessagesNl.php
- languages/MessagesLa.php
- languages/MessagesGsw.php
Comment 17 Rob Church 2006-06-24 23:30:47 UTC
Applied to SVN trunk, r15022.
Comment 18 Jimmy Collins 2006-06-24 23:50:24 UTC
Created attachment 2006 [details]
cleanup br-tags (not i18n), patch for trunk

The patch updates following files:
- math/texvc_cgi.ml
- config/index.php
- includes/SpecialRecentchanges.php
- includes/SpecialPreferences.php
Comment 19 Jimmy Collins 2006-07-02 13:02:50 UTC
Created attachment 2037 [details]
fix for hr- and br-tags in i18n (xhtml), patch for trunk

The attached patch fixes some br- and hr-tags in several language files
(MessagesXx.php)
Comment 20 Jimmy Collins 2006-07-02 21:22:52 UTC
(In reply to comment #18)
applied to SVN trunk, r15243

Comment 21 Jimmy Collins 2006-07-02 21:33:48 UTC
(In reply to comment #19)
applied to SVN trunk, r15245
Comment 22 Antoine "hashar" Musso (WMF) 2006-07-11 18:55:33 UTC
Comment on attachment 2006 [details]
cleanup br-tags (not i18n), patch for trunk

r15243
Comment 23 Antoine "hashar" Musso (WMF) 2006-07-11 18:55:37 UTC
Comment on attachment 2037 [details]
fix for hr- and br-tags in i18n (xhtml), patch for trunk

r15245

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links