Last modified: 2012-08-14 12:01:19 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T12204, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 10204 - Language.php missing else condition?


Summary:	Language.php missing else condition?

Status:	RESOLVED DUPLICATE of bug 10166

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	1.10.x
Hardware:	All All

Importance:	Normal minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2007-06-09 02:06 UTC by Brad Spencer
Modified:	2012-08-14 12:01 UTC (History)
CC List:	2 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Brad Spencer 2007-06-09 02:06:13 UTC

After installing 1.10.0, I got errors about "array_slice" needing an array for argument 1 in Language.php line 1139.

I applied this patch which seems to be the intent and it goes away.

Comment 1 Brad Spencer 2007-06-09 02:07:19 UTC

I can't see the attachment, but I presume it is there.

Just in case:

--- /home/spencer/sandbox/mediawiki-1.10.0/languages/Language.php       2007-04-19 15:47:04.000000000 -0300
+++ ./Language.php      2007-06-08 22:53:04.000000000 -0300
@@ -1134,9 +1134,10 @@

                if( !is_array( $rawEntry ) ) {
                        error_log( "\"$rawEntry\" is not a valid magic thingie for \"$mw->mId\"" );
-               }
-               $mw->mCaseSensitive = $rawEntry[0];
-               $mw->mSynonyms = array_slice( $rawEntry, 1 );
+               } else {
+                 $mw->mCaseSensitive = $rawEntry[0];
+                 $mw->mSynonyms = array_slice( $rawEntry, 1 );
+                }
        }

        /**

Comment 2 Rob Church 2007-06-11 06:40:19 UTC


*** This bug has been marked as a duplicate of bug 10166 ***

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links