Last modified: 2011-01-14 16:54:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 10158 - Don't mention allowing others to contact you if $wgEnableUserEmail=false
Don't mention allowing others to contact you if $wgEnableUserEmail=false
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User login and signup (Other open bugs)
1.10.x
All All
: Normal trivial (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy, patch
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-06-06 02:18 UTC by Dan Jacobson
Modified: 2011-01-14 16:54 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Proposed patch (3.61 KB, patch)
2009-05-13 02:08 UTC, jopiswezggzmw
Details

Description Dan Jacobson 2007-06-06 02:18:32 UTC
On Special:Userlogin we see

* E-mail (optional): Enables others to contact you through your user
  or user_talk page without needing to reveal your identity.

even though those capabilities are turned off, (no buttons on those
pages to do any contacting), using $wgEnableUserEmail=false;
$wgEmailAuthentication=$wgEnableEmail=true;

Indeed, in this case the message should just mention that one will get
a button to press when one forgets their password to have it sent.

Also mention that anyway.

Of course what they see upon account creation may not reflect the
state of the administrator has set the switches years later when they
attempt to use such features.

I see I have a report I was going to submit earlier for 1.9.2, I'm not
sure if it still applies. Here it is anyway:
-----------------------------------
Subject: $wgEnableUserEmail message but $wgEnableEmail test

Even if one does $wgEnableUserEmail = false;
On Special:Userlogin&type=signup users will still see

"* E-mail (optional): Enables others to contact you through your user
or user_talk page without needing to reveal your identity."

Same on Preferences, though indeed at least the related click box
disappears.

One has to $wgEnableEmail = false; to stop it.

So there should be two messages, one for each variable. Not just one.
Comment 1 Aaron Schulz 2008-12-29 19:09:16 UTC
Just edit the 'MediaWiki:prefs-help-email' page.
Comment 2 Brion Vibber 2008-12-29 19:15:19 UTC
The software should display messages which are relevant to the current configuration. Requiring that the messages be customized in every language that a visitor might want for something the software can detect itself seems subideal.
Comment 3 Aaron Schulz 2008-12-29 19:16:52 UTC
I'm not sure this is even worth the code really...
Comment 4 Brion Vibber 2008-12-29 20:33:20 UTC
The UI not being blatantly wrong is always worth the code.
Comment 5 Mary DeMelo 2009-03-28 13:17:18 UTC
Thank you 
Comment 6 jopiswezggzmw 2009-05-13 02:08:26 UTC
Created attachment 6111 [details]
Proposed patch

I've made changes to the login page and the preferences page, which I think are the only places this message is displayed.

I wasn't sure what the best way to implement the message was so I added a new 'prefs-help-email-limited' message with the unnecessary text omitted. Perhaps I should have instead broken 'prefs-help-email' up into two messages?

Hopefully this will be alright.
Comment 7 jopiswezggzmw 2009-06-08 21:40:26 UTC
Any chance someone could take a look at the patch?
Comment 8 Dan Jacobson 2009-06-09 00:25:07 UTC
You repeat the same sentence in the new message.
It would be better to redesign things so the sentences could be
inserted independently. Yes, that is not as simple as just making a
new message...
Comment 9 Karun 2009-12-20 22:48:40 UTC
The proposed patch requires review.
Comment 10 Antoine "hashar" Musso (WMF) 2011-01-14 16:54:31 UTC
Adapted and committed as r80281.

Should be in Mediawiki 1.18.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links