Last modified: 2011-03-13 18:06:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 10151 - Bad image list doesn't strip image parameters from link
Bad image list doesn't strip image parameters from link
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
All All
: Lowest minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: 12736 (view as bug list)
Depends on:
  Show dependency treegraph
Reported: 2007-06-05 20:34 UTC by Brion Vibber
Modified: 2011-03-13 18:06 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Description Brion Vibber 2007-06-05 20:34:19 UTC
When an image triggers the bad image list, the pipe side of the link is inserted raw as the link text as if it were a regular link.

This is less than ideal, and results in very broken rendering when parameters such as "thumb" or a pixel size are used. For instance this link:

  [[Image:Intimpiercing Frau Klit vorhaut.jpg|thumb|250px|Horizontal clitoral hood piercing.]]

renders as the text:

  |thumb|250px|Horizontal clitoral hood piercing.

when what might be expected would be just the caption text:

  Horizontal clitoral hood piercing.

There are a couple possible ways to deal with this. One would be to go ahead and run the link through Parser::makeImage()'s parameter processing and try to strip out any contained markup from the caption. This would maintain the current behavior in most simple cases (where a simple caption with no markup is present but no other parameters), while providing a relatively expected result when there's some light markup or use of parameters.

Another possibility would be to change the rendering to something like standard thumb/frame rendering, with a little click-through icon or explanatory note.
Comment 1 Raimond Spekking 2008-01-22 22:06:24 UTC
*** Bug 12736 has been marked as a duplicate of this bug. ***
Comment 2 Alex Z. 2008-01-22 23:36:39 UTC
It should probably give a warning when attempting to save, similar to the spam blacklist warning.
Comment 3 Max Semenik 2010-02-01 17:20:50 UTC
Current behaviour has changed, now such images are ignored completely.

Note You need to log in before you can comment on or make changes to this bug.