Last modified: 2011-03-13 18:06:41 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T12056, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 10056 - Checkboxes should be checked by default in Special:Undelete
Checkboxes should be checked by default in Special:Undelete
Product: MediaWiki
Classification: Unclassified
Special pages (Other open bugs)
All All
: Lowest enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: easy
Depends on:
  Show dependency treegraph
Reported: 2007-05-29 07:10 UTC by Yonatan Horan
Modified: 2011-03-13 18:06 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Really simple patch for this... (591 bytes, patch)
2007-05-29 07:39 UTC, Daniel Cannon (AmiDaniel)

Description Yonatan Horan 2007-05-29 07:10:39 UTC
The only times where the status of a checkbox matter are when you're doing a partial restore, in which case you'd probably want all the checkboxes do be checked by default so you can deselect the few revisions you don't want restored.
Comment 1 Daniel Cannon (AmiDaniel) 2007-05-29 07:39:41 UTC
Created attachment 3687 [details]
Really simple patch for this...

Piece of cake to do, patch attached -- if we want to do it, that is.
Comment 2 Daniel Cannon (AmiDaniel) 2007-05-29 07:56:36 UTC
Having talked to robchurch, there are *indeed* performance reasons why this is not done. Selecting all checkmarks requires that each of them be processed by timestamp as opposed to simply doing all in bulk in the default case of none-selected. This causes excessive and unnecessary load, especially since undelete-all is the most common case. Changing to WONTFIX and hunting down the bug this is a dupe of.
Comment 3 Aryeh Gregor (not reading bugmail, please e-mail directly) 2007-05-29 20:27:14 UTC
How about we add some intelligence and check if they're all selected, and in that case behave the same as with none selected?  Or better yet, if this is an issue, figure out whether it's best to come up with a list to delete or a list not to delete, to put in the appropriate WHERE clause.
Comment 4 Brion Vibber 2007-05-30 19:42:44 UTC
To know if they're all selected you'd have to read out the list again on submit. Possible though.
Comment 5 Raimond Spekking 2007-06-20 20:05:59 UTC
*** Bug 10323 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.