Last modified: 2007-05-29 07:09:26 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 10047 - SMW doesn't display several errors in Imported from
SMW doesn't display several errors in Imported from
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: S Page
http://ontoworld.org/wiki/SMW_unit_te...
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-05-28 03:52 UTC by S Page
Modified: 2007-05-29 07:09 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description S Page 2007-05-28 03:52:02 UTC
Errors arising from [[imported from:=foaf:bad]] or incorrect namespace aren't reported.
Comment 1 S Page 2007-05-28 04:30:23 UTC
I think the fix is just some typos in SMW_Factbox.php, this make the error handling like other code:

--- .	(revision 21705)
+++ .	(working copy)
@@ -188,8 +188,8 @@
 
 		if (NULL != $error) {
 			$datavalue = SMWDataValue::newTypedValue(new SMWErrorTypeHandler($error),$value);
-			if (!$smwgStoreActive) {
-				SMWFactbox::$semdata->addSpecialValue(SMW_SP_IMPORTED_FROM,$result);
+			if ($smwgStoreActive) {
+				SMWFactbox::$semdata->addSpecialValue(SMW_SP_IMPORTED_FROM, $datavalue);
 			}
 			return $datavalue;
 		}

I'm not sure about the check for smwgStoreActive but it works for me so I checked this in (SVN revision 22499).
Comment 2 Markus Krötzsch 2007-05-29 07:09:26 UTC
Thanks. There were more of the same typos in earlier versions, but this one escaped my fixes. It should be correct now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links