Last modified: 2007-10-16 03:00:08 UTC

Wikimedia Bugzilla is closed!

Wikimedia has migrated from Bugzilla to Phabricator. Bug reports should be created and updated in Wikimedia Phabricator instead. Please create an account in Phabricator and add your Bugzilla email address to it.
Wikimedia Bugzilla is read-only. If you try to edit or create any bug report in Bugzilla you will be shown an intentional error message.
In order to access the Phabricator task corresponding to a Bugzilla report, just remove "static-" from its URL.
You could still run searches in Bugzilla or access your list of votes but bug reports will obviously not be up-to-date in Bugzilla.
Bug 10033 - Patch makes EditPage more general
Patch makes EditPage more general
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.11.x
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-05-26 00:27 UTC by David McCabe
Modified: 2007-10-16 03:00 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
the patch (14.18 KB, patch)
2007-05-26 00:27 UTC, David McCabe
Details

Description David McCabe 2007-05-26 00:27:20 UTC
Created attachment 3679 [details]
the patch

I have made a simple change to EditPage.php in my liquidthreads branch. I would like it tested and put in the trunk to avoid merge headaches, because it's lots of little changes all over. In theory, no behavior should be changed at all, but it would be great if more people could test this.

The change is to use $this->mTitle for GUI stuff and $this->mArticle->getTitle() for content and wikitext stuff. This simple distinction, having the title of the page editpage is accessed from separate from the title of the page actually being edited, makes liquidthreads possible.

Until now, editpage has used $this->mTitle for everything, and this was assigned (and still is) to $wgTitle in __construct. But $this->mArticle is an argument to __construct, so calling code such as liquidthreads can edit pages other than the main page being accessed.

So test this out please, and if it doesn't break anything, put it in trunk. Thanks!

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links