Last modified: 2007-05-22 16:25:15 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T12004, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 10004 - Improper comparison of foo and [foo (bar)|foo]
Improper comparison of foo and [foo (bar)|foo]
Status: RESOLVED INVALID
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2007-05-22 14:30 UTC by Mb Bret
Modified: 2007-05-22 16:25 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Mb Bret 2007-05-22 14:30:49 UTC
In an article contains the word "foo", when an edition is made to transform the plain word "foo" into a link with the syntax "[[foo (bar)|foo]]", the history page suffers from a bad comparison algorithm.

More specifically:
If "foo" is edited into "[[foo (bar)|foo]]", the comparison page identifies the original foo with the one in "[[foo (bar)...", as showned by the highlted text. It should identify it with the second foo, in "...|foo]]"

See for instance:
http://en.wikipedia.org/w/index.php?title=Okay&diff=132676520&oldid=132567604

Note that, on the contrary, the identification is correct when editing
"[[foo]]" into "[[foo (bar)|foo]]"
or
"foo" into "[[bar|foo]]"
Comment 1 Brion Vibber 2007-05-22 15:29:36 UTC
General simplicity and logical consistency would favor the first match, as with all other such changes.
Comment 2 Mb Bret 2007-05-22 16:16:44 UTC
On the contrary, when you change a text for a link with a tag, you should compare the text to the tag, while the title of the article that is linked may be completly different for the sake of disambiguation. Other changes behave as I expect: when "[[foo1]]" is changed to "[[foo2 (bar)|foo3]]", foo1 and foo3 are compared. (Note that in this case, [[foo1]] was already a link. The bug appears when it is nota link in the first place)
Comment 3 Phil Boswell 2007-05-22 16:25:15 UTC
You are assuming that the comparison algorithm has any knowledge of wikitext syntax: it does not, it is a simple text comparison.

Such an intelligent comparison might be possible in the future but not right now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links