Last modified: 2014-11-10 13:16:06 UTC
VE no longer has iframes. I don't really understand how "iframe_element" is being used: $ grep -r "iframe_element" * features/step_definitions/language_screenshot_steps.rb: on(VisualEditorPage).iframe_element.when_present.should be_visible features/step_definitions/language_screenshot_steps.rb: on(VisualEditorPage).iframe_element.when_present.should be_visible features/step_definitions/language_screenshot_steps.rb: capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element], nil, -2) features/step_definitions/language_screenshot_steps.rb: on(VisualEditorPage).iframe_element.when_present.should be_visible features/step_definitions/language_screenshot_steps.rb: capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element], nil, -2) features/step_definitions/language_screenshot_steps.rb: on(VisualEditorPage).iframe_element.when_present.should be_visible features/step_definitions/language_screenshot_steps.rb: capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element], nil, 0) features/step_definitions/language_screenshot_steps.rb: capture_screenshot("VisualEditor_Page_Settings_Redirects-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.page_settings_heading_element, @current_page.prevent_redirect_element], @current_page.iframe_element, 0) features/step_definitions/language_screenshot_steps.rb: capture_screenshot("VisualEditor_Page_Settings_TOC-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.table_of_contents_element], @current_page.iframe_element, 0) features/step_definitions/language_screenshot_steps.rb: capture_screenshot("VisualEditor_Page_Settings_Edit_Links-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.page_settings_editlinks_element], @current_page.iframe_element, 0) features/step_definitions/language_screenshot_steps.rb: capture_screenshot("VisualEditor_Apply_Changes-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.settings_apply_button_element], @current_page.iframe_element, 3) features/step_definitions/language_screenshot_steps.rb: capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.link_list_element, @current_page.iframe_element, @current_page.new_link_element], nil, 0) features/step_definitions/language_screenshot_steps.rb: on(VisualEditorPage).iframe_element.when_present.should be_visible features/step_definitions/language_screenshot_steps.rb: capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element]) features/step_definitions/language_screenshot_steps.rb: on(VisualEditorPage).iframe_element.when_present.should be_visible features/step_definitions/language_screenshot_steps.rb: capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element], nil, 0) features/step_definitions/language_screenshot_steps.rb: capture_screenshot("VisualEditor_Media_alternative_text-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.media_alternative_block_element], @current_page.iframe_element) features/step_definitions/language_screenshot_steps.rb: on(VisualEditorPage).iframe_element.when_present.should be_visible features/step_definitions/language_screenshot_steps.rb: capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element], nil, 0) features/step_definitions/language_screenshot_steps.rb: on(VisualEditorPage).iframe_element.when_present.should be_visible features/step_definitions/language_screenshot_steps.rb: capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element]) features/step_definitions/language_screenshot_steps.rb: page.iframe_element.when_present.should be_visible features/step_definitions/language_screenshot_steps.rb: capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element, @current_page.formula_image_element], nil, 0) features/step_definitions/language_screenshot_steps.rb: on(VisualEditorPage).iframe_element.when_present.should be_visible features/step_definitions/language_screenshot_steps.rb: capture_screenshot("#{@scenario.name}-#{ENV['LANGUAGE_SCREENSHOT_CODE']}.png", [@current_page.iframe_element], nil, 0)
Vikas, can you take a look? Amir, if Vikas does not have the time to fix this, we could work on it during our regular pairing sessions.
Change 171531 had a related patch set uploaded by Vikassy: Fixed failing browser tests https://gerrit.wikimedia.org/r/171531
Change 171531 merged by jenkins-bot: [BrowserTest] Fixed failing language screenshot browser tests https://gerrit.wikimedia.org/r/171531