Last modified: 2014-07-23 14:10:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T70410, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 68410 - forms module is poorly nested inside controllers
forms module is poorly nested inside controllers
Status: RESOLVED FIXED
Product: Analytics
Classification: Unclassified
Wikimetrics (Other open bugs)
unspecified
All All
: Unprioritized normal
: ---
Assigned To: Nobody - You can work on this!
u=Kevin c=Reviews p=0 s=2014-07-10
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-22 22:16 UTC by Dan Andreescu
Modified: 2014-07-23 14:10 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Dan Andreescu 2014-07-22 22:16:35 UTC 
The wikimetrics/controllers/forms folder causes anyone who imports from forms to import the entire controller suite.  Also, the wikimetrics/metrics/form_fields module really belongs inside this forms folder.  This bug has become a problem because people adding simple features like: https://gerrit.wikimedia.org/r/#/c/138151/ are running into circular dependencies after rebasing.

Fix: make it so rebasing https://gerrit.wikimedia.org/r/#/c/138151/ on top of the fix eliminates the circular dependencies.
Comment 1 Gerrit Notification Bot 2014-07-22 22:52:42 UTC 
Change 148537 had a related patch set uploaded by Milimetric:
Fix bad dependency chains and imports

https://gerrit.wikimedia.org/r/148537
Comment 2 Gerrit Notification Bot 2014-07-23 09:03:24 UTC 
Change 148537 merged by jenkins-bot:
Fix bad dependency chains and imports

https://gerrit.wikimedia.org/r/148537
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links