Last modified: 2014-02-14 16:14:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T63328, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 61328 - [Regex] CVE http links mangled
[Regex] CVE http links mangled
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Bugzilla (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Tim Landscheidt
: easy
Depends on: 45772
Blocks:
  Show dependency tree / graph
 
Reported: 2014-02-13 18:54 UTC by Tim Landscheidt
Modified: 2014-02-14 16:14 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Tim Landscheidt 2014-02-13 18:54:23 UTC 
The links in bug #60112, comment #8 are mangled:

- http://people.canonical.com/~ubuntu-security/cve/2013/CVE-2013-7106.html
- http://people.canonical.com/~ubuntu-security/cve/2013/CVE-2013-7107.html
- http://people.canonical.com/~ubuntu-security/cve/2013/CVE-2013-7108.html

This seems to come from wikimedia/bugzilla/modifications:extensions/Wikimedia/Extension.pm's $replacerCVE.  There probably needs to be a look-behind assertion in front of the \b.
Comment 1 Andre Klapper 2014-02-13 19:27:55 UTC 
Introduced in bug 45772 - I blame Reedy who wrote this. ;)

Whoever likes to play with regexes is invited to provide a patch ( https://www.mediawiki.org/wiki/Gerrit/Tutorial ) for https://git.wikimedia.org/blob/wikimedia%2Fbugzilla%2Fmodifications.git/HEAD/extensions%2FWikimedia%2FExtension.pm#L71
Comment 2 Gerrit Notification Bot 2014-02-13 20:08:18 UTC 
Change 113170 had a related patch set uploaded by Tim Landscheidt:
Add exemption to the CVE linker for Ubuntu security links

https://gerrit.wikimedia.org/r/113170
Comment 3 Gerrit Notification Bot 2014-02-14 16:04:08 UTC 
Change 113170 merged by Dzahn:
Add exemption to the CVE linker for Ubuntu security links

https://gerrit.wikimedia.org/r/113170
Comment 4 Daniel Zahn 2014-02-14 16:05:42 UTC 
deployed, please confirm
Comment 5 Tim Landscheidt 2014-02-14 16:14:18 UTC 
Bug #60112, comment #8 shows nicely both kinds of links are working correctly.  Thanks!
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links