Last modified: 2014-02-07 01:18:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T62309, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 60309 - Flow: new-topic should fail on page that isn't a Flow board
Flow: new-topic should fail on page that isn't a Flow board
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Flow (Other open bugs)
master
All All
: High major (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2014-01-21 22:52 UTC by spage
Modified: 2014-02-07 01:18 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description spage 2014-01-21 22:52:58 UTC
As in bug 60218. Go to [[mw:Special:ApiSandbox]]:
* action=flow
* page= page you want to blank, one that isn't a Flow board.
* params={"topic_list": {"topic": "Topic!", "content": "Content!"}}
* token=Flow token from API (request tokens type 'flow'), +\ if you're logged out

Press Make request, and the page will be replaced with the string: "This talk
page has been taken over by a
[https://www.mediawiki.org/wiki/Special:MyLanguage/Flow_Portal Flow board]."
The API request returns success and includes the chunk of HTML for the new topic.

But the page isn't a Flow board! The API request should fail.
onPerformAction checks isTalkpageOccupied but returns true if it isn't, and maybe the API should be checking too before it calls ensureFlowRevision().
Comment 1 Bingle 2014-01-21 22:54:31 UTC
The WMF core features team tracks this bug on Mingle card https://wikimedia.mingle.thoughtworks.com/projects/flow/cards/733, but people from the community are welcome to contribute here and in Gerrit.
Comment 2 Gerrit Notification Bot 2014-01-30 21:47:58 UTC
Change 110458 had a related patch set uploaded by EBernhardson:
Limit Flow API to only respond on enabled pages

https://gerrit.wikimedia.org/r/110458
Comment 3 Gerrit Notification Bot 2014-02-04 19:57:46 UTC
Change 110458 merged by jenkins-bot:
Limit Flow API to only respond on enabled pages

https://gerrit.wikimedia.org/r/110458

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links