Last modified: 2013-08-29 21:50:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T52055, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 50055 - Parsoid: Leading "<" in HTML comment dropped in template inside reference
Parsoid: Leading "<" in HTML comment dropped in template inside reference
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: High major
: ---
Assigned To: ssastry
https://en.wikipedia.org/w/index.php?...
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2013-06-23 16:01 UTC by James Forrester
Modified: 2013-08-29 21:50 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description James Forrester 2013-06-23 16:01:11 UTC 
Possibly related to wider issues; to investigate.
Comment 1 Ed Sanders 2013-06-23 19:26:24 UTC 
{{echo|foo<!--bar-->quux}}

serialises correctly to:

<p about="#mwt1" typeof="mw:Transclusion" data-mw="{&quot;target&quot;:{&quot;wt&quot;:&quot;echo&quot;,&quot;href&quot;:&quot;./Template:Echo&quot;},&quot;params&quot;:{&quot;1&quot;:{&quot;wt&quot;:&quot;foo<!--bar-->quux&quot;}}}" data-parsoid="{&quot;dsr&quot;:[0,26,null,null],&quot;src&quot;:&quot;{{echo|foo<!--bar-->quux}}&quot;}">fooquux</p>

but then round trips back to:

{{echo|fooquuxbar-->quux}}

where the '<' has been replaced by the contents after the comment.
Comment 2 Gerrit Notification Bot 2013-06-23 19:59:16 UTC 
Related URL: https://gerrit.wikimedia.org/r/70063 (Gerrit Change I0af5889e7bccd0f659df9d4aa1feba9d977d1871)
Comment 3 Gerrit Notification Bot 2013-06-24 16:07:31 UTC 
https://gerrit.wikimedia.org/r/70063 (Gerrit Change I0af5889e7bccd0f659df9d4aa1feba9d977d1871) | change APPROVED and MERGED [by jenkins-bot]
Comment 4 Gabriel Wicke 2013-06-24 17:24:59 UTC 
Fixed. Will be deployed later today.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links