Last modified: 2014-02-12 23:39:51 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47284, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45284 - Bad defaults for review radio buttons when commenting on old patchsets
Bad defaults for review radio buttons when commenting on old patchsets
Status: NEW
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
wmf-deployment
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-22 16:39 UTC by Brad Jorsch
Modified: 2014-02-12 23:39 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Brad Jorsch 2013-02-22 16:39:22 UTC
When commenting on an old patchset, the radio buttons for the review levels default incorrectly. It looks like it's defaulting to the review levels on the current patchset, instead of the review levels previously set on the patchset being commented on.

This makes it easy to accidentally mark an old patchset as 0 or even +1 when you really intended it to stay as -1. See for example https://gerrit.wikimedia.org/r/#/c/49781/, several of the later comments on PS1 remove the -1s because the radio buttons took the 0 from the later patchset.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links