Last modified: 2013-02-20 21:46:12 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T47191, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 45191 - Gerrit init.d default file mismatch
Gerrit init.d default file mismatch
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2013-02-20 11:34 UTC by Antoine "hashar" Musso (WMF)
Modified: 2013-02-20 21:46 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2013-02-20 11:34:53 UTC
The Gerrit init script look for /etc/default/gerritcodereview. Both our debian package and the puppet manifests install a /etc/default/gerrit which is thus never loaded rendering the init script useless.

Both our Gerrit package and the puppet manifest provide the same content.


To avoid changing upstream init script, we would want to update our Gerrit debian package to isntall the default as gerritcodereview and then to update our puppet manifest to use the same name /etc/default/gerritcodereview.  Or maybe strip the puppet part since it is redundant with the package.
Comment 1 Chad H. 2013-02-20 15:57:19 UTC
Yeah, this was changed from gerrit to gerritcodereview at some point. I updated the init script when we upgraded, but the puppet manifest was never changed.

Have done that now in Gerrit change #50016.
Comment 2 Chad H. 2013-02-20 21:46:12 UTC
This is fixed now.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links