Last modified: 2012-02-24 02:52:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T33660, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 31660 - Remove old version of the phonegap.jar library
Remove old version of the phonegap.jar library
Status: RESOLVED FIXED
Product: Wikipedia App
Classification: Unclassified
Generic (Other open bugs)
1.0.0 (Android)
All All
: Normal minor
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2011-10-12 23:12 UTC by Sam Reed (reedy)
Modified: 2012-02-24 02:52 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: Android
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2011-10-12 23:12:56 UTC 
Do we really need the 1.0 and 1.1 versions of phonegap.jar?

If not, remove version 1.0
Comment 1 Tomasz Finc 2011-10-13 07:57:53 UTC 
Were not quite ready to move over everything to 1.1. Removing it currently generates the following errors

dMenu cannot be resolved or is not a field	AppMenu.java	/wikipedia- android/src/com/phonegap/menu	line 126	Java Problem

The method buildMenu(Menu) of type AppMenu must override or implement a supertype method	AppMenu.java	/wikipedia-android/src/com/phonegap/menu	line 72	Java Problem

The method isMenuChanged() of type AppMenu must override or implement a supertype method	AppMenu.java	/wikipedia-android/src/com/phonegap/menu	line 59	Java Problem
Comment 2 Sam Reed (reedy) 2011-10-13 16:19:16 UTC 
That seems slightly weird, has the phonegap API changed that much? Weird

Certainly be good to get it out before release, as I'd guess Java will load both into memory and that's just extra bloat we don't want to inflict on our users for too long into the future!
Comment 3 Brion Vibber 2011-10-13 16:20:27 UTC 
The dMenu bit in AppMenu doesn't work anyway (that's the "crashes on 3.x" bug).
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links