Last modified: 2011-08-17 14:50:19 UTC
Created attachment 8921 [details] Two message existence checks are inverted r80248 broke messages on page protection forms by inverting two message existence checks. The result is that protection levels are all displayed as “Require "X" permission” (not mentioning what would happen for custom protection levels…), and fieldset legends list the action identifier instead of their localized meaning. See the attached patch for a fix.
Fixed in r80341, r80408, and r80252.
(In reply to comment #1) > Fixed in r80341, r80408, and r80252. No, not fixed, not in those revisions, and not anywhere else. Would you please see the patch, notice it is for ProtectionForm.php, and verify that none of those revisions touched this file? Or you might just take a look at the current http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/includes/ProtectionForm.php?view=markup#l360 and realize that $msg->exists() ? $action : $msg->text() is _really_ a strange logic. Or maybe just look at a live protection form on a trunk MediaWiki and see the broken behavior?
Fixed in r94761.