Last modified: 2014-11-18 18:07:27 UTC
The new reject button that shows up for reviewers is too easy to confuse with the accept button (especially when one is patrolling a lot of revisions in a short time). There should be an obvious visual clue to tell them apart, like green/red color.
I had a coloring scheme, but it was removed (but not replaced with anything).
We did intend to replace it with something (e.g. icons on the buttons), but didn't have time for the proper solution. I felt pretty strongly that the current all-black, all-the-time button text was better than the button scheme, which I think Brandon concurred with me on (though I'm not positive I checked wiht him). Anyway, it's good we have an issue logged to make sure we do this right. Assigning to Brandon for a quick mockup when he gets the chance.
The reject button shouldn't be a button if we can avoid it. It should just be a text link.
(In reply to comment #3) > The reject button shouldn't be a button if we can avoid it. It should just be > a text link. Then accept shouldn't be a button too for consistency.
Not necessarily. To be honest, the entire accept/reject/unaccept interface should have a totally different UI. But the resources to make it so aren't there right now (and won't be committed unless we have further sign off). I suppose the question really is this: "is it possible to undo a 'reject'" and if the answer is no or 'yes but very difficult or tedious' then we should downplay reject. We know we can always revert an accept.
(In reply to comment #5) > I suppose the question really is this: "is it possible to undo a 'reject'" and > if the answer is no or 'yes but very difficult or tedious' then we should > downplay reject. We know we can always revert an accept. It is difficult (and pollutes page history), but as long as you need two clicks for the reject, that isn't much of a problem. Mistaking the options (or even just having to think about which one to choose) wastes patrollers' time, though.